From patchwork Wed Aug 31 02:11:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 9306249 X-Patchwork-Delegate: Trond.Myklebust@netapp.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2177D607F0 for ; Wed, 31 Aug 2016 02:12:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10BEA28DE7 for ; Wed, 31 Aug 2016 02:12:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05CC928E17; Wed, 31 Aug 2016 02:12:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B23D728DE7 for ; Wed, 31 Aug 2016 02:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758233AbcHaCMU (ORCPT ); Tue, 30 Aug 2016 22:12:20 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:35624 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758117AbcHaCMS (ORCPT ); Tue, 30 Aug 2016 22:12:18 -0400 Received: by mail-it0-f67.google.com with SMTP id f128so4119829ith.2 for ; Tue, 30 Aug 2016 19:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=pVg3T/XL78T3aFOv+dWiXOjyodpUDS/FMClyxBAloSM=; b=Br2Dq/2HX37PWXvODui+s3cF6xczQOJWc3dvxB3IzDeVeTHGkI9W7/+PobOaTaBu2G xyguGwTzQFKGU6/SolG2IM23Q2w7rcGFEM4wnrYv1pRWGYNs4QQ2U+aGymmYjDc9DCk+ 44d6sEFyu5aZyROb6ZGL8gNv4WU9+aKcLF+Mm8o3sehCerB1fEoDiJ49EI46EOm+Tkz3 8zUkO6CkIcZzLbSIc6L8+UuFuLg7Bfmgcq6kgB614RIeYHHsKqqxgw4ak4ehMJctEdIn 9TJjkA6XvWhjhZTg8bZvh1v1v5TvyaZq6DgGGMxb9YnWPHUsJ+8Waqzlu25YX0D4bGiQ KULw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=pVg3T/XL78T3aFOv+dWiXOjyodpUDS/FMClyxBAloSM=; b=c9M8CiFtxPB3tCk0sTvyOsZewRVv/hXpsXru53+F1BHZ8RKhPE982Dn1wsegRAofIf s3DTPd4FSn4MP1xyvA3CwOTmnSzz+ImkYi4Dwcu/7h6bQ9Kj8gmljZuBOBn97qEhLDuW GklpUAvnkfKvsGgASb7d5ewd5qNc+kwBUQ2TUiqu6KrU3kNUOqNmbUJWqlazkz3mYc/U dh7VTfBH2hTc1WzkukTSUe+pCPIFQ3gT9XDFGDwbsUaYerC6qpEBfFYVMWBCVBoCo8qD B+ecPMIlEY94Td3201+CWbBKMNAKXJPhfbPB6V7t4D4oNOBlEwwo5F0JoSF1nWvRFfvu jV+A== X-Gm-Message-State: AE9vXwMX4vesHfnEcJ5r2GeIYqdXKiuY18AH6iikuBACKTrEUohcgRTSv5g6k4WQF8mQ4w== X-Received: by 10.36.99.2 with SMTP id j2mr27101455itc.72.1472609537954; Tue, 30 Aug 2016 19:12:17 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id x77sm895268ioi.3.2016.08.30.19.12.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Aug 2016 19:12:17 -0700 (PDT) From: Trond Myklebust To: anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org Subject: [PATCH 7/7] NFSv4.1: Don't recheck delegations that have already been checked Date: Tue, 30 Aug 2016 22:11:44 -0400 Message-Id: <1472609504-69094-8-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1472609504-69094-7-git-send-email-trond.myklebust@primarydata.com> References: <1472609504-69094-1-git-send-email-trond.myklebust@primarydata.com> <1472609504-69094-2-git-send-email-trond.myklebust@primarydata.com> <1472609504-69094-3-git-send-email-trond.myklebust@primarydata.com> <1472609504-69094-4-git-send-email-trond.myklebust@primarydata.com> <1472609504-69094-5-git-send-email-trond.myklebust@primarydata.com> <1472609504-69094-6-git-send-email-trond.myklebust@primarydata.com> <1472609504-69094-7-git-send-email-trond.myklebust@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Ensure we don't spam the server with test_stateid() calls for delegations that have already been checked. Signed-off-by: Trond Myklebust --- fs/nfs/nfs4proc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 412f1daf1515..9c8c7400b048 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2456,6 +2456,11 @@ static void nfs41_check_delegation_stateid(struct nfs4_state *state) return; } + if (!test_and_clear_bit(NFS_DELEGATION_TEST_EXPIRED, &delegation->flags)) { + rcu_read_unlock(); + return; + } + cred = get_rpccred(delegation->cred); rcu_read_unlock(); status = nfs41_test_and_free_expired_stateid(server, &stateid, cred);