xfs: add XBF_XBF_NO_IOACCT to buf trace output
diff mbox

Message ID 4074f575-f4cf-e8ee-7c79-0bbc45333f5d@redhat.com
State Accepted
Headers show

Commit Message

Eric Sandeen Sept. 8, 2016, 9:53 p.m. UTC
When XBF_NO_IOACCT got added, it missed the translation
in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
than the flag name.  Fix it.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Eric Sandeen Oct. 3, 2016, 3:01 p.m. UTC | #1
Ping?

On 9/8/16 4:53 PM, Eric Sandeen wrote:
> When XBF_NO_IOACCT got added, it missed the translation
> in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
> than the flag name.  Fix it.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
> index 1c2e52b..424f6b0 100644
> --- a/fs/xfs/xfs_buf.h
> +++ b/fs/xfs/xfs_buf.h
> @@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
>  	{ XBF_READ,		"READ" }, \
>  	{ XBF_WRITE,		"WRITE" }, \
>  	{ XBF_READ_AHEAD,	"READ_AHEAD" }, \
> +	{ XBF_NO_IOACCT,	"NO_IOACCT" }, \
>  	{ XBF_ASYNC,		"ASYNC" }, \
>  	{ XBF_DONE,		"DONE" }, \
>  	{ XBF_STALE,		"STALE" }, \
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Brian Foster Oct. 3, 2016, 3:31 p.m. UTC | #2
On Thu, Sep 08, 2016 at 04:53:28PM -0500, Eric Sandeen wrote:
> When XBF_NO_IOACCT got added, it missed the translation
> in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
> than the flag name.  Fix it.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---

Thought I caught that, apparently not. Thanks!

Reviewed-by: Brian Foster <bfoster@redhat.com>

> 
> diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
> index 1c2e52b..424f6b0 100644
> --- a/fs/xfs/xfs_buf.h
> +++ b/fs/xfs/xfs_buf.h
> @@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
>  	{ XBF_READ,		"READ" }, \
>  	{ XBF_WRITE,		"WRITE" }, \
>  	{ XBF_READ_AHEAD,	"READ_AHEAD" }, \
> +	{ XBF_NO_IOACCT,	"NO_IOACCT" }, \
>  	{ XBF_ASYNC,		"ASYNC" }, \
>  	{ XBF_DONE,		"DONE" }, \
>  	{ XBF_STALE,		"STALE" }, \
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Sandeen Nov. 10, 2016, 4:41 p.m. UTC | #3
On 10/3/16 10:31 AM, Brian Foster wrote:
> On Thu, Sep 08, 2016 at 04:53:28PM -0500, Eric Sandeen wrote:
>> When XBF_NO_IOACCT got added, it missed the translation
>> in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
>> than the flag name.  Fix it.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
> 
> Thought I caught that, apparently not. Thanks!
> 
> Reviewed-by: Brian Foster <bfoster@redhat.com>

Dave, ping on a merge for this?  It has Brian's review.

Thanks,
-Eric
 
>>
>> diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
>> index 1c2e52b..424f6b0 100644
>> --- a/fs/xfs/xfs_buf.h
>> +++ b/fs/xfs/xfs_buf.h
>> @@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
>>  	{ XBF_READ,		"READ" }, \
>>  	{ XBF_WRITE,		"WRITE" }, \
>>  	{ XBF_READ_AHEAD,	"READ_AHEAD" }, \
>> +	{ XBF_NO_IOACCT,	"NO_IOACCT" }, \
>>  	{ XBF_ASYNC,		"ASYNC" }, \
>>  	{ XBF_DONE,		"DONE" }, \
>>  	{ XBF_STALE,		"STALE" }, \
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
index 1c2e52b..424f6b0 100644
--- a/fs/xfs/xfs_buf.h
+++ b/fs/xfs/xfs_buf.h
@@ -71,6 +71,7 @@  typedef unsigned int xfs_buf_flags_t;
 	{ XBF_READ,		"READ" }, \
 	{ XBF_WRITE,		"WRITE" }, \
 	{ XBF_READ_AHEAD,	"READ_AHEAD" }, \
+	{ XBF_NO_IOACCT,	"NO_IOACCT" }, \
 	{ XBF_ASYNC,		"ASYNC" }, \
 	{ XBF_DONE,		"DONE" }, \
 	{ XBF_STALE,		"STALE" }, \