diff mbox

[v4] dt-bindings: Add jdi lt070me05000 panel bindings

Message ID 1473311672-20782-1-git-send-email-simhavcs@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vinay Simha B N Sept. 8, 2016, 5:14 a.m. UTC
Add documentation for lt070me05000 panel

Cc: Archit Taneja <archit.taneja@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>

---
v2:
 * incorporated rob herring and thierry reviews
   gpio to gpios, gpio to regulator using fixed regulators
   and pwm backlight is removed, since it is controlled by
   dcs commands

v3:
 * incorporated thierry reviews
   - Added gpio polarity details for reset-gpios
   - proper naming conventions and sequence wrt panel datasheet
     (vddp-supply, iovcc-supply,
      enable-gpios, reset-gpios, dcdc-en-gpios)
v4:
 * pinctrl-names, pinctrl-0 removed, not required for
   reset-gpios
---
 .../bindings/display/panel/jdi,lt070me05000.txt    | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt

Comments

Vinay Simha B N Sept. 15, 2016, 2:45 p.m. UTC | #1
Hi Tierry,

Could you please review the patch and integrate?

On Thu, Sep 8, 2016 at 10:44 AM, Vinay Simha BN <simhavcs@gmail.com> wrote:

> Add documentation for lt070me05000 panel
>
> Cc: Archit Taneja <archit.taneja@gmail.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
>
> ---
> v2:
>  * incorporated rob herring and thierry reviews
>    gpio to gpios, gpio to regulator using fixed regulators
>    and pwm backlight is removed, since it is controlled by
>    dcs commands
>
> v3:
>  * incorporated thierry reviews
>    - Added gpio polarity details for reset-gpios
>    - proper naming conventions and sequence wrt panel datasheet
>      (vddp-supply, iovcc-supply,
>       enable-gpios, reset-gpios, dcdc-en-gpios)
> v4:
>  * pinctrl-names, pinctrl-0 removed, not required for
>    reset-gpios
> ---
>  .../bindings/display/panel/jdi,lt070me05000.txt    | 31
> ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/jdi,
> lt070me05000.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
> b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
> new file mode 100644
> index 0000000..4989c91d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
> @@ -0,0 +1,31 @@
> +JDI model LT070ME05000 1200x1920 7" DSI Panel
> +
> +Required properties:
> +- compatible: should be "jdi,lt070me05000"
> +- vddp-supply: phandle of the regulator that provides the supply voltage
> +  Power IC supply (3-5V)
> +- iovcc-supply: phandle of the regulator that provides the supply voltage
> +  IOVCC , power supply for LCM (1.8V)
> +- enable-gpios: phandle of gpio for enable line
> +  LED_EN, LED backlight enable, High active
> +- reset-gpios: phandle of gpio for reset line
> +  This should be 8mA, gpio can be configured using mux, pinctrl,
> pinctrl-names
> +  XRES, Reset, Low active
> +- dcdc-en-gpios: phandle of the gpio for power ic line
> +  Power IC supply enable, High active
> +
> +Example:
> +
> +       dsi0: qcom,mdss_dsi@4700000 {
> +               panel@0 {
> +                       compatible = "jdi,lt070me05000";
> +                       reg = <0>;
> +
> +                       vddp-supply = <&pm8921_l17>;
> +                       iovcc-supply = <&pm8921_lvs7>;
> +
> +                       enable-gpios = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>;
> +                       reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;
> +                       dcdc-en-gpios = <&pm8921_gpio 23 GPIO_ACTIVE_HIGH>;
> +               };
> +       };
> --
> 2.1.2
>
>
Thierry Reding Sept. 16, 2016, 3:31 p.m. UTC | #2
On Thu, Sep 08, 2016 at 10:44:22AM +0530, Vinay Simha BN wrote:
> Add documentation for lt070me05000 panel
> 
> Cc: Archit Taneja <archit.taneja@gmail.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
> 
> ---
> v2:
>  * incorporated rob herring and thierry reviews
>    gpio to gpios, gpio to regulator using fixed regulators
>    and pwm backlight is removed, since it is controlled by
>    dcs commands
> 
> v3:
>  * incorporated thierry reviews
>    - Added gpio polarity details for reset-gpios
>    - proper naming conventions and sequence wrt panel datasheet
>      (vddp-supply, iovcc-supply,
>       enable-gpios, reset-gpios, dcdc-en-gpios)
> v4:
>  * pinctrl-names, pinctrl-0 removed, not required for
>    reset-gpios
> ---
>  .../bindings/display/panel/jdi,lt070me05000.txt    | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt

Applied, with a modified commit message.

Thanks,
Thierry
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
new file mode 100644
index 0000000..4989c91d
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
@@ -0,0 +1,31 @@ 
+JDI model LT070ME05000 1200x1920 7" DSI Panel
+
+Required properties:
+- compatible: should be "jdi,lt070me05000"
+- vddp-supply: phandle of the regulator that provides the supply voltage
+  Power IC supply (3-5V)
+- iovcc-supply: phandle of the regulator that provides the supply voltage
+  IOVCC , power supply for LCM (1.8V)
+- enable-gpios: phandle of gpio for enable line
+  LED_EN, LED backlight enable, High active
+- reset-gpios: phandle of gpio for reset line
+  This should be 8mA, gpio can be configured using mux, pinctrl, pinctrl-names
+  XRES, Reset, Low active
+- dcdc-en-gpios: phandle of the gpio for power ic line
+  Power IC supply enable, High active
+
+Example:
+
+	dsi0: qcom,mdss_dsi@4700000 {
+		panel@0 {
+			compatible = "jdi,lt070me05000";
+			reg = <0>;
+
+			vddp-supply = <&pm8921_l17>;
+			iovcc-supply = <&pm8921_lvs7>;
+
+			enable-gpios = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>;
+			reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;
+			dcdc-en-gpios = <&pm8921_gpio 23 GPIO_ACTIVE_HIGH>;
+		};
+	};