| Message ID | 20160910165949.3507-1-nicolas.iooss_linux@m4x.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello, I sent the following patch (available on https://patchwork.kernel.org/patch/9325039/) a few weeks ago and got no feedback even though the bug it fixes seems to still exist in linux-next. Did I do something wrong, like sending to the wrong maintainers? Thanks, Nicolas On 10/09/16 18:59, Nicolas Iooss wrote: > Function ite_set_carrier_params() uses variable use_demodulator after > having initialized it to false in some if branches, but this variable is > never set to true otherwise. > > This bug has been found using clang -Wsometimes-uninitialized warning > flag. > > Fixes: 620a32bba4a2 ("[media] rc: New rc-based ite-cir driver for > several ITE CIRs") > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > --- > drivers/media/rc/ite-cir.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c > index 0f301903aa6f..63165d324fff 100644 > --- a/drivers/media/rc/ite-cir.c > +++ b/drivers/media/rc/ite-cir.c > @@ -263,6 +263,8 @@ static void ite_set_carrier_params(struct ite_dev *dev) > > if (allowance > ITE_RXDCR_MAX) > allowance = ITE_RXDCR_MAX; > + > + use_demodulator = true; > } > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c index 0f301903aa6f..63165d324fff 100644 --- a/drivers/media/rc/ite-cir.c +++ b/drivers/media/rc/ite-cir.c @@ -263,6 +263,8 @@ static void ite_set_carrier_params(struct ite_dev *dev) if (allowance > ITE_RXDCR_MAX) allowance = ITE_RXDCR_MAX; + + use_demodulator = true; } }
Function ite_set_carrier_params() uses variable use_demodulator after having initialized it to false in some if branches, but this variable is never set to true otherwise. This bug has been found using clang -Wsometimes-uninitialized warning flag. Fixes: 620a32bba4a2 ("[media] rc: New rc-based ite-cir driver for several ITE CIRs") Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> --- drivers/media/rc/ite-cir.c | 2 ++ 1 file changed, 2 insertions(+)