PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency
diff mbox

Message ID 20160915154513.3006199-1-arnd@arndb.de
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Arnd Bergmann Sept. 15, 2016, 3:44 p.m. UTC
The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
a 'select' statement, and that in turn has a dependency on
PM_DEVFREQ_EVENT, which may be disabled here:

warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)

We probably want a 'depends on' here, but other drivers use 'select'
too, so for consistency I'm doing the same.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
---
 drivers/devfreq/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Chanwoo Choi Sept. 16, 2016, 12:26 p.m. UTC | #1
Hi Arnd,

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Best Regards,
Chanwoo Choi

2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
> a 'select' statement, and that in turn has a dependency on
> PM_DEVFREQ_EVENT, which may be disabled here:
>
> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>
> We probably want a 'depends on' here, but other drivers use 'select'
> too, so for consistency I'm doing the same.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
> ---
>  drivers/devfreq/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 93b6ada06676..41254e702f1e 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -105,6 +105,7 @@ config ARM_RK3399_DMC_DEVFREQ
>         depends on ARCH_ROCKCHIP
>         select DEVFREQ_EVENT_ROCKCHIP_DFI
>         select DEVFREQ_GOV_SIMPLE_ONDEMAND
> +       select PM_DEVFREQ_EVENT
>         select PM_OPP
>         help
>            This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
> --
> 2.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
MyungJoo Ham Sept. 19, 2016, 7:46 a.m. UTC | #2
2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the

> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through

> a 'select' statement, and that in turn has a dependency on

> PM_DEVFREQ_EVENT, which may be disabled here:

>

> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)

>

> We probably want a 'depends on' here, but other drivers use 'select'

> too, so for consistency I'm doing the same.

>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")



Thank you.


Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>



Being tested at: https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/log/?h=for-4.9-rc


@ The branch above requires additional patches to be tested
(other rockchip support drivers to be merged for 4.9 and COMPILE_TEST retraction for TEGRA)
Rafael J. Wysocki Sept. 19, 2016, 11:09 a.m. UTC | #3
On Mon, Sep 19, 2016 at 9:46 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> 2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
>> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
>> a 'select' statement, and that in turn has a dependency on
>> PM_DEVFREQ_EVENT, which may be disabled here:
>>
>> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>>
>> We probably want a 'depends on' here, but other drivers use 'select'
>> too, so for consistency I'm doing the same.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
>
>
> Thank you.
>
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

I've applied this one directly.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 93b6ada06676..41254e702f1e 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -105,6 +105,7 @@  config ARM_RK3399_DMC_DEVFREQ
 	depends on ARCH_ROCKCHIP
 	select DEVFREQ_EVENT_ROCKCHIP_DFI
 	select DEVFREQ_GOV_SIMPLE_ONDEMAND
+	select PM_DEVFREQ_EVENT
 	select PM_OPP
 	help
           This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).