xfs_io: allow chattr & chproj on foreign filesystems
diff mbox

Message ID e1471cdf-9f83-91d1-9e93-f3877baeccb5@redhat.com
State Accepted
Headers show

Commit Message

Eric Sandeen Sept. 17, 2016, 1 a.m. UTC
Now that FS_IOC_FSSETXATTR is a generic vfs call, these
functions can be used on non-xfs filesystems, and this is
needed for generic project quota testing.

(not all flags are valid on all filesystems.)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Christoph Hellwig Sept. 25, 2016, 2:34 p.m. UTC | #1
On Fri, Sep 16, 2016 at 08:00:39PM -0500, Eric Sandeen wrote:
> Now that FS_IOC_FSSETXATTR is a generic vfs call, these
> functions can be used on non-xfs filesystems, and this is
> needed for generic project quota testing.
> 
> (not all flags are valid on all filesystems.)
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Patch
diff mbox

diff --git a/io/attr.c b/io/attr.c
index 0186b1d..d1962f3 100644
--- a/io/attr.c
+++ b/io/attr.c
@@ -340,7 +340,7 @@  attr_init(void)
 	chattr_cmd.args = _("[-R|-D] [+/-"CHATTR_XFLAG_LIST"]");
 	chattr_cmd.argmin = 1;
 	chattr_cmd.argmax = -1;
-	chattr_cmd.flags = CMD_NOMAP_OK;
+	chattr_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
 	chattr_cmd.oneline =
 		_("change extended inode flags on the currently open file");
 	chattr_cmd.help = chattr_help;
diff --git a/io/open.c b/io/open.c
index a5d465a..3eaa013 100644
--- a/io/open.c
+++ b/io/open.c
@@ -929,7 +929,7 @@  open_init(void)
 	chproj_cmd.args = _("[-D | -R] projid");
 	chproj_cmd.argmin = 1;
 	chproj_cmd.argmax = -1;
-	chproj_cmd.flags = CMD_NOMAP_OK;
+	chproj_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
 	chproj_cmd.oneline =
 		_("change project identifier on the currently open file");
 	chproj_cmd.help = chproj_help;