| Message ID | 1474354100-6092-1-git-send-email-axel.lin@ingics.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi, If you remove the mutex, you better to remove the header "#include <linux/mutex.h>" from exynos-ppmu.c. If you remove the header file, looks good to me and feel free to add my tag. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Best Regards, Chanwoo Choi On 2016년 09월 20일 15:48, Axel Lin wrote: > The mutex is not used at all, remove it. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/devfreq/event/exynos-ppmu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index f55cf0e..251692b 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -15,7 +15,6 @@ > #include <linux/io.h> > #include <linux/kernel.h> > #include <linux/module.h> > -#include <linux/mutex.h> > #include <linux/of_address.h> > #include <linux/platform_device.h> > #include <linux/suspend.h> > @@ -34,7 +33,6 @@ struct exynos_ppmu { > unsigned int num_events; > > struct device *dev; > - struct mutex lock; > > struct exynos_ppmu_data ppmu; > }; > @@ -463,7 +461,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev) > if (!info) > return -ENOMEM; > > - mutex_init(&info->lock); > info->dev = &pdev->dev; > > /* Parse dt data to get resource */ > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2016-09-20 16:07 GMT+08:00 Chanwoo Choi <cw00.choi@samsung.com>: > Hi, > > If you remove the mutex, you better to remove > the header "#include <linux/mutex.h>" from exynos-ppmu.c. Yes, I did remove it in this path. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index f55cf0e..251692b 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -15,7 +15,6 @@ #include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/mutex.h> #include <linux/of_address.h> #include <linux/platform_device.h> #include <linux/suspend.h> @@ -34,7 +33,6 @@ struct exynos_ppmu { unsigned int num_events; struct device *dev; - struct mutex lock; struct exynos_ppmu_data ppmu; }; @@ -463,7 +461,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev) if (!info) return -ENOMEM; - mutex_init(&info->lock); info->dev = &pdev->dev; /* Parse dt data to get resource */
The mutex is not used at all, remove it. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/devfreq/event/exynos-ppmu.c | 3 --- 1 file changed, 3 deletions(-)