| Message ID | 20160921000211.GH8319@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 20/09/2016 at 17:02:11 -0700, Stephen Boyd wrote : > On 09/20, Alexandre Belloni wrote: > > Move all clocks related to the slow clock controller to sckc.c. This avoids > > extern definitions and allows to remove sckc.h > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > Applied to clk-next > Thanks for the fix! > drivers/clk/at91/sckc.c:146:13: > warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:260:13: > warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:359:13: > warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared. > Should it be static? > > ----8<---- > diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c > index f6ed711af738..311956abf4aa 100644 > --- a/drivers/clk/at91/sckc.c > +++ b/drivers/clk/at91/sckc.c > @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_name; > @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > u32 frequency = 0; > @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_names[2]; > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project
diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index f6ed711af738..311956abf4aa 100644 --- a/drivers/clk/at91/sckc.c +++ b/drivers/clk/at91/sckc.c @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; const char *parent_name; @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; u32 frequency = 0; @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; const char *parent_names[2];