| Message ID | 1474929911-6005-2-git-send-email-o-takashi@sakamocchi.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Mark, On Sep 27 2016 07:45, Takashi Sakamoto wrote: > Sparse reports a below warning. > > sound/soc/codecs/da7219.c:804:57: warning: dubious: x & !y > > The line includes a condition statement; '(a < b) & !c'. Practically, the > evaluated value of this statement equals to the value of '(a < b) && !c'. > Although, it's not an usual way to use bitwise operations as logical > operations to several conditions. > > This commit fixes the bug. > > Fixes: 6d817c0e9fd7 ("ASoC: codecs: Add da7219 codec driver") > Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> > Cc: Support Opensource <support.opensource@diasemi.com> > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > --- > sound/soc/codecs/da7219.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c > index 50ea943..b9fa8fe 100644 > --- a/sound/soc/codecs/da7219.c > +++ b/sound/soc/codecs/da7219.c > @@ -801,7 +801,7 @@ static int da7219_dai_event(struct snd_soc_dapm_widget *w, > ++i; > msleep(50); > } > - } while ((i < DA7219_SRM_CHECK_RETRIES) & (!srm_lock)); > + } while ((i < DA7219_SRM_CHECK_RETRIES) && (!srm_lock)); > > if (!srm_lock) > dev_warn(codec->dev, "SRM failed to lock\n"); I have never received your 'applied' message to this patch, while received the others. This patch should be abandoned? or I should send v2 with corrected subject line? Regards Takashi Sakamoto
On Wed, Sep 28, 2016 at 09:38:31AM +0900, Takashi Sakamoto wrote: > I have never received your 'applied' message to this patch, while > received the others. > This patch should be abandoned? or I should send v2 with corrected > subject line? Please allow a reasonable time for review and for other people to commment on your changes, this change was not so trivial as your other changes so I've allowed longer for review. You sent a series consisting of a bunch of unrelated changes, it's likely if you do that that some of them will get handled differently.
On Sep 29 2016 01:49, Mark Brown wrote: > On Wed, Sep 28, 2016 at 09:38:31AM +0900, Takashi Sakamoto wrote: > >> I have never received your 'applied' message to this patch, while >> received the others. > >> This patch should be abandoned? or I should send v2 with corrected >> subject line? > > Please allow a reasonable time for review and for other people to > commment on your changes, this change was not so trivial as your other > changes so I've allowed longer for review. You sent a series consisting > of a bunch of unrelated changes, it's likely if you do that that some of > them will get handled differently. Hm. Your way to apply submitted patches is different from the others, at least, Iwai-san, Jaroslav and Greg. They rarely apply a part of patches in a patchset. I'm puzzled again for this sub-sub-system, ASoC. Anyway, thanks. Takashi Sakamoto
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 50ea943..b9fa8fe 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -801,7 +801,7 @@ static int da7219_dai_event(struct snd_soc_dapm_widget *w, ++i; msleep(50); } - } while ((i < DA7219_SRM_CHECK_RETRIES) & (!srm_lock)); + } while ((i < DA7219_SRM_CHECK_RETRIES) && (!srm_lock)); if (!srm_lock) dev_warn(codec->dev, "SRM failed to lock\n");
Sparse reports a below warning. sound/soc/codecs/da7219.c:804:57: warning: dubious: x & !y The line includes a condition statement; '(a < b) & !c'. Practically, the evaluated value of this statement equals to the value of '(a < b) && !c'. Although, it's not an usual way to use bitwise operations as logical operations to several conditions. This commit fixes the bug. Fixes: 6d817c0e9fd7 ("ASoC: codecs: Add da7219 codec driver") Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> Cc: Support Opensource <support.opensource@diasemi.com> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> --- sound/soc/codecs/da7219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)