| Message ID | 1475034250-6909-1-git-send-email-eguan@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 28, 2016 at 11:44:09AM +0800, Eryu Guan wrote: > generic/052 was made generic from an xfs test, and generic functions > should be used not the xfs-specific ones. > > Signed-off-by: Eryu Guan <eguan@redhat.com> Looks good. Reviewed-by: Dave Chinner <dchinner@redhat.com> > --- > tests/generic/052 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/052 b/tests/generic/052 > index a81885b..74cf5b6 100755 > --- a/tests/generic/052 > +++ b/tests/generic/052 > @@ -72,7 +72,7 @@ _print_logstate > > # curious if FS consistent at start > if false; then > - if _xfs_check $SCRATCH_DEV; then > + if _check_scratch_fs; then > echo "*** checked ok ***" > fi > fi > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On Wed, Sep 28, 2016 at 11:44:09AM +0800, Eryu Guan wrote: > generic/052 was made generic from an xfs test, and generic functions > should be used not the xfs-specific ones. > > Signed-off-by: Eryu Guan <eguan@redhat.com> > --- > tests/generic/052 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/052 b/tests/generic/052 > index a81885b..74cf5b6 100755 > --- a/tests/generic/052 > +++ b/tests/generic/052 > @@ -72,7 +72,7 @@ _print_logstate > > # curious if FS consistent at start > if false; then > - if _xfs_check $SCRATCH_DEV; then > + if _check_scratch_fs; then Looks good to me. Test passed on newest upstream kernel+xfsprogs and RHEL-6. Reviewed-by: Zorro Lang <zlang@redhat.com> > echo "*** checked ok ***" > fi > fi > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/generic/052 b/tests/generic/052 index a81885b..74cf5b6 100755 --- a/tests/generic/052 +++ b/tests/generic/052 @@ -72,7 +72,7 @@ _print_logstate # curious if FS consistent at start if false; then - if _xfs_check $SCRATCH_DEV; then + if _check_scratch_fs; then echo "*** checked ok ***" fi fi
generic/052 was made generic from an xfs test, and generic functions should be used not the xfs-specific ones. Signed-off-by: Eryu Guan <eguan@redhat.com> --- tests/generic/052 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)