| Message ID | 1475073244-23068-3-git-send-email-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | Under Review, archived |
| Headers | show |
On Wed, Sep 28, 2016 at 04:34:02PM +0200, Benjamin Tissoires wrote: > it's always easier to retrieve these information in bug reports when > it is always printed in the dmesg. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/input/mouse/elan_i2c_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c > index d15b338..2de1f75 100644 > --- a/drivers/input/mouse/elan_i2c_core.c > +++ b/drivers/input/mouse/elan_i2c_core.c > @@ -1093,7 +1093,7 @@ static int elan_probe(struct i2c_client *client, > if (error) > return error; > > - dev_dbg(&client->dev, > + dev_info(&client->dev, > "Elan Touchpad Information:\n" > " Module product ID: 0x%04x\n" > " Firmware Version: 0x%04x\n" The format is acceptable for dev_dbg, but this multi-line output is not too nice for normal logging, especially as we probe the device asynchronously so there can easily be more output from other kernel threads. Thanks.
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index d15b338..2de1f75 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c @@ -1093,7 +1093,7 @@ static int elan_probe(struct i2c_client *client, if (error) return error; - dev_dbg(&client->dev, + dev_info(&client->dev, "Elan Touchpad Information:\n" " Module product ID: 0x%04x\n" " Firmware Version: 0x%04x\n"
it's always easier to retrieve these information in bug reports when it is always printed in the dmesg. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/input/mouse/elan_i2c_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)