ASoC: sun4i-i2s: fix odd_ptr_err.cocci warnings
diff mbox

Message ID alpine.DEB.2.10.1610041820390.3213@hadrien
State New
Headers show

Commit Message

Julia Lawall Oct. 4, 2016, 4:23 p.m. UTC
sound/soc/sunxi/sun4i-i2s.c:633:5-11: inconsistent IS_ERR and PTR_ERR on line 635.

 PTR_ERR should normally access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 sun4i-i2s.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Oct. 5, 2016, 11:38 a.m. UTC | #1
On Tue, Oct 04, 2016 at 06:23:24PM +0200, Julia Lawall wrote:
> sound/soc/sunxi/sun4i-i2s.c:633:5-11: inconsistent IS_ERR and PTR_ERR on line 635.
> 
>  PTR_ERR should normally access the value just tested by IS_ERR
> 
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Looks like a good catch but this doesn't apply against current code,
please check and resend.

Patch
diff mbox

--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -632,7 +632,7 @@  static int sun4i_i2s_probe(struct platfo
 	reset_apb = devm_reset_control_get(&pdev->dev, "apb_reset");
 	if (IS_ERR(reset_apb)) {
 		dev_err(&pdev->dev, "Can't get apb reset\n");
-		return PTR_ERR(i2s->mod_clk);
+		return PTR_ERR(reset_apb);
 	}

 	ret = reset_control_deassert(reset_apb);