| Message ID | 1475709604-5045-1-git-send-email-anusha.srivatsa@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote: > Proper functioning of HuC requires GuC to be > loaded. Make GuC loads default so that HuC works > seemlessly. > Also, note that GuC submission is not made default > and still needs to be given as a kernel parameter. > Once the issues around GuC submission is resolved it > is intended to make it default as well. <broken record>Why is this even a separate parameter?</> -Chris
>-----Original Message----- >From: Chris Wilson [mailto:chris@chris-wilson.co.uk] >Sent: Wednesday, October 5, 2016 11:57 PM >To: Srivatsa, Anusha <anusha.srivatsa@intel.com> >Cc: intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default > >On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote: >> Proper functioning of HuC requires GuC to be loaded. Make GuC loads >> default so that HuC works seemlessly. >> Also, note that GuC submission is not made default and still needs to >> be given as a kernel parameter. >> Once the issues around GuC submission is resolved it is intended to >> make it default as well. > ><broken record>Why is this even a separate parameter?</> -Chris It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function. Anusha >-- >Chris Wilson, Intel Open Source Technology Centre
I also asked that same question many times. Maybe they can be unified later when we enable submission by default, but right now I believe this is the way to go, so Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> On Thu, Oct 6, 2016 at 11:03 AM, Srivatsa, Anusha <anusha.srivatsa@intel.com> wrote: > > >>-----Original Message----- >>From: Chris Wilson [mailto:chris@chris-wilson.co.uk] >>Sent: Wednesday, October 5, 2016 11:57 PM >>To: Srivatsa, Anusha <anusha.srivatsa@intel.com> >>Cc: intel-gfx@lists.freedesktop.org >>Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default >> >>On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote: >>> Proper functioning of HuC requires GuC to be loaded. Make GuC loads >>> default so that HuC works seemlessly. >>> Also, note that GuC submission is not made default and still needs to >>> be given as a kernel parameter. >>> Once the issues around GuC submission is resolved it is intended to >>> make it default as well. >> >><broken record>Why is this even a separate parameter?</> -Chris > > It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function. > > Anusha >>-- >>Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Could someone please ack this? We need this before getting HuC. GuC submission has regressions so the submission is not getting enabled. But we need to have GuC loaded to be able to use HuC. Thanks, Rodrigo. On Thu, Oct 6, 2016 at 11:08 AM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote: > I also asked that same question many times. Maybe they can be unified > later when we enable submission by default, but right now I believe > this is the way to go, so > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > On Thu, Oct 6, 2016 at 11:03 AM, Srivatsa, Anusha > <anusha.srivatsa@intel.com> wrote: >> >> >>>-----Original Message----- >>>From: Chris Wilson [mailto:chris@chris-wilson.co.uk] >>>Sent: Wednesday, October 5, 2016 11:57 PM >>>To: Srivatsa, Anusha <anusha.srivatsa@intel.com> >>>Cc: intel-gfx@lists.freedesktop.org >>>Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default >>> >>>On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote: >>>> Proper functioning of HuC requires GuC to be loaded. Make GuC loads >>>> default so that HuC works seemlessly. >>>> Also, note that GuC submission is not made default and still needs to >>>> be given as a kernel parameter. >>>> Once the issues around GuC submission is resolved it is intended to >>>> make it default as well. >>> >>><broken record>Why is this even a separate parameter?</> -Chris >> >> It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function. >> >> Anusha >>>-- >>>Chris Wilson, Intel Open Source Technology Centre >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br
I agree that the parameter controls could use a clean-up, which could include eventual removal of the enable_guc_loading parameter. But for now loading parameter should be auto by default. Might be a good idea to temporarily set the has_guc parameter to 0 for BXT and KBL since those firmwares have not yet been made available (I don't see them on 01.org). In either case... Reviewed-by: Jeff McGee <jeff.mcgee@intel.com> On Mon, Oct 31, 2016 at 10:06:27AM -0700, Rodrigo Vivi wrote: > Could someone please ack this? We need this before getting HuC. > > GuC submission has regressions so the submission is not getting enabled. > But we need to have GuC loaded to be able to use HuC. > > Thanks, > Rodrigo. > > On Thu, Oct 6, 2016 at 11:08 AM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote: > > I also asked that same question many times. Maybe they can be unified > > later when we enable submission by default, but right now I believe > > this is the way to go, so > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > > > On Thu, Oct 6, 2016 at 11:03 AM, Srivatsa, Anusha > > <anusha.srivatsa@intel.com> wrote: > >> > >> > >>>-----Original Message----- > >>>From: Chris Wilson [mailto:chris@chris-wilson.co.uk] > >>>Sent: Wednesday, October 5, 2016 11:57 PM > >>>To: Srivatsa, Anusha <anusha.srivatsa@intel.com> > >>>Cc: intel-gfx@lists.freedesktop.org > >>>Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default > >>> > >>>On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote: > >>>> Proper functioning of HuC requires GuC to be loaded. Make GuC loads > >>>> default so that HuC works seemlessly. > >>>> Also, note that GuC submission is not made default and still needs to > >>>> be given as a kernel parameter. > >>>> Once the issues around GuC submission is resolved it is intended to > >>>> make it default as well. > >>> > >>><broken record>Why is this even a separate parameter?</> -Chris > >> > >> It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function. > >> > >> Anusha > >>>-- > >>>Chris Wilson, Intel Open Source Technology Centre > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > > > > > -- > > Rodrigo Vivi > > Blog: http://blog.vivi.eng.br > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 768ad89..256a512 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -55,7 +55,7 @@ struct i915_params i915 __read_mostly = { .verbose_state_checks = 1, .nuclear_pageflip = 0, .edp_vswing = 0, - .enable_guc_loading = 0, + .enable_guc_loading = -1, .enable_guc_submission = 0, .guc_log_level = -1, .enable_dp_mst = true, @@ -209,7 +209,7 @@ MODULE_PARM_DESC(edp_vswing, module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400); MODULE_PARM_DESC(enable_guc_loading, "Enable GuC firmware loading " - "(-1=auto, 0=never [default], 1=if available, 2=required)"); + "(-1=auto [default], 0=never, 1=if available, 2=required )"); module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400); MODULE_PARM_DESC(enable_guc_submission,
Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly. Also, note that GuC submission is not made default and still needs to be given as a kernel parameter. Once the issues around GuC submission is resolved it is intended to make it default as well. It is now safe to make GuC loads default. Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)