latest version of bluetooth for n950?

Commit Message

Pavel Machek Oct. 11, 2016, 7:47 a.m. UTC

Hi, Sebastian!

I got some free cycles to play with n900 and bluetooth. There's still
some unrelated config option that breaks even the old vesion of
patches, but I'm ready for more debugging now.

Could I have the latest version of the (clean) bluetooth patch? I have
feeling it might work with the right config option, and would like to
try.

For the record, here's working .config and the tricky tricky oneliner
that took me week to figure out.

Best regards,
									Pavel

Comments

Sebastian Reichel Oct. 11, 2016, 2:51 p.m. UTC | #1

Hi,

On Tue, Oct 11, 2016 at 09:47:04AM +0200, Pavel Machek wrote:
> Hi, Sebastian!
> 
> I got some free cycles to play with n900 and bluetooth. There's still
> some unrelated config option that breaks even the old vesion of
> patches, but I'm ready for more debugging now.
> 
> Could I have the latest version of the (clean) bluetooth patch? I have
> feeling it might work with the right config option, and would like to
> try.
> 
> For the record, here's working .config and the tricky tricky oneliner
> that took me week to figure out.

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-n900.git/log/?h=n950-bluetooth

My local branch is based on 4.8 and fixes a few of Marcel's
comments. I'm currently at ELCE, but I will push my local
stuff later in the hotel after verifying, that it works as
expected (luckily I brought N950 with me :)).

The work I push will not yet be using Rob's (Herring) work
based on serio (I'm working on that). I think his patches
should go in first, so that we avoid introducing userspace
API, that we do not really want (hciattach).

-- Sebastian

Sebastian Reichel Oct. 11, 2016, 9:41 p.m. UTC | #2

Hi,

On Tue, Oct 11, 2016 at 04:51:40PM +0200, Sebastian Reichel wrote:
> On Tue, Oct 11, 2016 at 09:47:04AM +0200, Pavel Machek wrote:
> > I got some free cycles to play with n900 and bluetooth. There's still
> > some unrelated config option that breaks even the old vesion of
> > patches, but I'm ready for more debugging now.
> > 
> > Could I have the latest version of the (clean) bluetooth patch? I have
> > feeling it might work with the right config option, and would like to
> > try.
> > 
> > For the record, here's working .config and the tricky tricky oneliner
> > that took me week to figure out.
> 
> https://git.kernel.org/cgit/linux/kernel/git/sre/linux-n900.git/log/?h=n950-bluetooth
> 
> My local branch is based on 4.8 and fixes a few of Marcel's
> comments. I'm currently at ELCE, but I will push my local
> stuff later in the hotel after verifying, that it works as
> expected (luckily I brought N950 with me :)).

It does not. Rebasing the pushed branch to v4.8 works, so the
problem is somewhere in my new changes. I will try to have a
look at it tomorrow.

The changes shouldn't affect you for any tests, though. Just
take the branch from above (and optionally rebase to v4.8).

-- Sebastian

Patch

diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h
index b4c0484..1304009 100644
--- a/include/uapi/linux/serial_reg.h
+++ b/include/uapi/linux/serial_reg.h
@@ -32,7 +32,7 @@ 
 
 #define UART_IIR	2	/* In:  Interrupt ID Register */
 #define UART_IIR_NO_INT		0x01 /* No interrupts pending */
-#define UART_IIR_ID		0x0e /* Mask for the interrupt ID */
+#define UART_IIR_ID		0x06 /* Mask for the interrupt ID */
 #define UART_IIR_MSI		0x00 /* Modem status interrupt */
 #define UART_IIR_THRI		0x02 /* Transmitter holding register empty */
 #define UART_IIR_RDI		0x04 /* Receiver data interrupt */