[1/2] drm/i915/dmc: Make no_stepping_info an array
diff mbox

Message ID 1476489364-6484-1-git-send-email-anusha.srivatsa@intel.com
State New
Headers show

Commit Message

Srivatsa, Anusha Oct. 14, 2016, 11:56 p.m. UTC
Make no_stepping_info an array of structs so that
on plaforms that have only one binary of DMC, we can
iterate through this array by having the same logic
for firmware loads

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Saarinen, Jani Oct. 17, 2016, 6:04 a.m. UTC | #1
> == Series Details ==

> 

> Series: series starting with [1/2] drm/i915/dmc: Make no_stepping_info an

> array

> URL   : https://patchwork.freedesktop.org/series/13818/

> State : warning

> 

> == Summary ==

> 

> Series 13818v1 Series without cover letter

> https://patchwork.freedesktop.org/api/1.0/series/13818/revisions/1/mbox/

> 

> Test drv_module_reload_basic:

>                 pass       -> SKIP       (fi-skl-6770hq)

Unstable
> Test kms_flip:

>         Subgroup basic-flip-vs-wf_vblank:

>                 dmesg-warn -> PASS       (fi-skl-6700k)

>                 dmesg-warn -> PASS       (fi-skl-6770hq)

> Test kms_pipe_crc_basic:

>         Subgroup read-crc-pipe-a-frame-sequence:

>                 dmesg-warn -> PASS       (fi-ilk-650)

>         Subgroup read-crc-pipe-b:

>                 dmesg-warn -> PASS       (fi-ilk-650)

>         Subgroup suspend-read-crc-pipe-a:

>                 pass       -> DMESG-WARN (fi-byt-j1900)

https://bugs.freedesktop.org/show_bug.cgi?id=98040

>         Subgroup suspend-read-crc-pipe-c:

>                 incomplete -> PASS       (fi-skl-6700k)

> Test vgem_basic:

>         Subgroup unload:

>                 pass       -> SKIP       (fi-bdw-5557u)

>                 pass       -> SKIP       (fi-hsw-4770)

>                 skip       -> PASS       (fi-skl-6770hq)

Unstable...

> 

> fi-bdw-5557u     total:246  pass:230  dwarn:0   dfail:0   fail:0   skip:16

> fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42

> fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30

> fi-byt-j1900     total:246  pass:212  dwarn:2   dfail:0   fail:1   skip:31

> fi-byt-n2820     total:246  pass:210  dwarn:0   dfail:0   fail:1   skip:35

> fi-hsw-4770      total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23

> fi-hsw-4770r     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22

> fi-ilk-650       total:246  pass:184  dwarn:0   dfail:0   fail:2   skip:60

> fi-ivb-3520m     total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25

> fi-ivb-3770      total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25

> fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24

> fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14

> fi-skl-6700hq    total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23

> fi-skl-6700k     total:246  pass:221  dwarn:1   dfail:0   fail:0   skip:24

> fi-skl-6770hq    total:246  pass:229  dwarn:1   dfail:0   fail:1   skip:15

> fi-snb-2520m     total:246  pass:210  dwarn:0   dfail:0   fail:0   skip:36

> fi-snb-2600      total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37

> 

> Results at /archive/results/CI_IGT_test/Patchwork_2731/

> 

> 38ecbe9082e477953fe165265c76e6c6061aeaf6 drm-intel-nightly: 2016y-10m-

> 14d-16h-23m-48s UTC integration manifest 6c7e89b drm/i915/DMC/KBL:

> Load DMC on KBL using he no_stepping_info array

> a43c6e5 drm/i915/dmc: Make no_stepping_info an array

> 


Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Rodrigo Vivi Oct. 17, 2016, 5:15 p.m. UTC | #2
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


On Fri, 2016-10-14 at 16:56 -0700, Anusha Srivatsa wrote:
> Make no_stepping_info an array of structs so that

> on plaforms that have only one binary of DMC, we can

> iterate through this array by having the same logic

> for firmware loads

> 

> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

> ---

>  drivers/gpu/drm/i915/intel_csr.c | 6 ++++--

>  1 file changed, 4 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c

> index 1ea0e1f..cf57167 100644

> --- a/drivers/gpu/drm/i915/intel_csr.c

> +++ b/drivers/gpu/drm/i915/intel_csr.c

> @@ -186,7 +186,9 @@ static const struct stepping_info bxt_stepping_info[] = {

>  	{'B', '0'}, {'B', '1'}, {'B', '2'}

>  };

>  

> -static const struct stepping_info no_stepping_info = { '*', '*' };

> +static const struct stepping_info no_stepping_info[] = {

> +	{ '*', '*' }

> +};

>  

>  static const struct stepping_info *

>  intel_get_stepping_info(struct drm_i915_private *dev_priv)

> @@ -210,7 +212,7 @@ intel_get_stepping_info(struct drm_i915_private *dev_priv)

>  	if (INTEL_REVID(dev_priv) < size)

>  		return si + INTEL_REVID(dev_priv);

>  

> -	return &no_stepping_info;

> +	return no_stepping_info;

>  }

>  

>  static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 1ea0e1f..cf57167 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -186,7 +186,9 @@  static const struct stepping_info bxt_stepping_info[] = {
 	{'B', '0'}, {'B', '1'}, {'B', '2'}
 };
 
-static const struct stepping_info no_stepping_info = { '*', '*' };
+static const struct stepping_info no_stepping_info[] = {
+	{ '*', '*' }
+};
 
 static const struct stepping_info *
 intel_get_stepping_info(struct drm_i915_private *dev_priv)
@@ -210,7 +212,7 @@  intel_get_stepping_info(struct drm_i915_private *dev_priv)
 	if (INTEL_REVID(dev_priv) < size)
 		return si + INTEL_REVID(dev_priv);
 
-	return &no_stepping_info;
+	return no_stepping_info;
 }
 
 static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)