| Message ID | 20161021080601.GA28738@elgon.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > submit_context() should return negative error codes and zero on success > but by mistake we made it a bool. I've changed it to int. Also I made > it static because this isn't referenced in any other files. > > This doesn't affect runtime because the return is eventually propogated > to elsp_mmio_write() where it is ignored. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c > index c50a3d1a5131..bc69ba1842ea 100644 > --- a/drivers/gpu/drm/i915/gvt/execlist.c > +++ b/drivers/gpu/drm/i915/gvt/execlist.c > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) > (list_empty(q) ? NULL : container_of(q->prev, \ > struct intel_vgpu_workload, list)) > > -bool submit_context(struct intel_vgpu *vgpu, int ring_id, > +static int submit_context(struct intel_vgpu *vgpu, int ring_id, > struct execlist_ctx_descriptor_format *desc, > bool emulate_schedule_in) > { Dan, this has been fixed in our recent pull, should hit linux-next very soon. thanks
On Fri, Oct 21, 2016 at 11:06:01AM +0300, Dan Carpenter wrote: > submit_context() should return negative error codes and zero on success > but by mistake we made it a bool. I've changed it to int. Also I made > it static because this isn't referenced in any other files. > > This doesn't affect runtime because the return is eventually propogated > to elsp_mmio_write() where it is ignored. Thanks Dan, your work in finding these is always appreciated (as is smatch!) Should be fixed by commit 76a79d59ada00fa22e5f8cd94b36296f395c3406 Author: Du, Changbin <changbin.du@intel.com> Date: Thu Oct 20 14:08:48 2016 +0800 drm/i915/gvt: fix spare warnings on odd constant _Bool cast The function return values should has type int if it return a integer value. -Chris
On Fri, Oct 21, 2016 at 04:27:38PM +0800, Zhenyu Wang wrote: > On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > > submit_context() should return negative error codes and zero on success > > but by mistake we made it a bool. I've changed it to int. Also I made > > it static because this isn't referenced in any other files. > > > > This doesn't affect runtime because the return is eventually propogated > > to elsp_mmio_write() where it is ignored. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c > > index c50a3d1a5131..bc69ba1842ea 100644 > > --- a/drivers/gpu/drm/i915/gvt/execlist.c > > +++ b/drivers/gpu/drm/i915/gvt/execlist.c > > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) > > (list_empty(q) ? NULL : container_of(q->prev, \ > > struct intel_vgpu_workload, list)) > > > > -bool submit_context(struct intel_vgpu *vgpu, int ring_id, > > +static int submit_context(struct intel_vgpu *vgpu, int ring_id, > > struct execlist_ctx_descriptor_format *desc, > > bool emulate_schedule_in) > > { > > Dan, this has been fixed in our recent pull, should hit linux-next very soon. > Could you review elsp_mmio_write() as well? Should we be doing something with that return value? regards, dan carpenter
On 2016.10.21 13:27:22 +0300, Dan Carpenter wrote: > On Fri, Oct 21, 2016 at 04:27:38PM +0800, Zhenyu Wang wrote: > > On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > > > submit_context() should return negative error codes and zero on success > > > but by mistake we made it a bool. I've changed it to int. Also I made > > > it static because this isn't referenced in any other files. > > > > > > This doesn't affect runtime because the return is eventually propogated > > > to elsp_mmio_write() where it is ignored. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > > > > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c > > > index c50a3d1a5131..bc69ba1842ea 100644 > > > --- a/drivers/gpu/drm/i915/gvt/execlist.c > > > +++ b/drivers/gpu/drm/i915/gvt/execlist.c > > > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) > > > (list_empty(q) ? NULL : container_of(q->prev, \ > > > struct intel_vgpu_workload, list)) > > > > > > -bool submit_context(struct intel_vgpu *vgpu, int ring_id, > > > +static int submit_context(struct intel_vgpu *vgpu, int ring_id, > > > struct execlist_ctx_descriptor_format *desc, > > > bool emulate_schedule_in) > > > { > > > > Dan, this has been fixed in our recent pull, should hit linux-next very soon. > > > > Could you review elsp_mmio_write() as well? Should we be doing > something with that return value? > yeah, ignore return value is not good, will fix that. Thanks! Zhi, could you double check error path for elsp write?
diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c index c50a3d1a5131..bc69ba1842ea 100644 --- a/drivers/gpu/drm/i915/gvt/execlist.c +++ b/drivers/gpu/drm/i915/gvt/execlist.c @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) (list_empty(q) ? NULL : container_of(q->prev, \ struct intel_vgpu_workload, list)) -bool submit_context(struct intel_vgpu *vgpu, int ring_id, +static int submit_context(struct intel_vgpu *vgpu, int ring_id, struct execlist_ctx_descriptor_format *desc, bool emulate_schedule_in) {
submit_context() should return negative error codes and zero on success but by mistake we made it a bool. I've changed it to int. Also I made it static because this isn't referenced in any other files. This doesn't affect runtime because the return is eventually propogated to elsp_mmio_write() where it is ignored. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>