From patchwork Fri Oct 21 13:01:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 9389011 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 33FE6607D0 for ; Fri, 21 Oct 2016 13:01:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 24F5F2A195 for ; Fri, 21 Oct 2016 13:01:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 199FF2A197; Fri, 21 Oct 2016 13:01:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F052E2A195 for ; Fri, 21 Oct 2016 13:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933805AbcJUNBQ (ORCPT ); Fri, 21 Oct 2016 09:01:16 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:55756 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932807AbcJUNBO (ORCPT ); Fri, 21 Oct 2016 09:01:14 -0400 Received: from localhost (localhost [127.0.0.1]) by s-opensource.com (Postfix) with ESMTP id 2AB8AA0DFA; Fri, 21 Oct 2016 13:01:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osg.samsung.com Received: from s-opensource.com ([127.0.0.1]) by localhost (s-opensource.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qe7CLT8O6KOk; Fri, 21 Oct 2016 13:01:18 +0000 (UTC) Received: from vento.lan (177.205.67.60.dynamic.adsl.gvt.net.br [177.205.67.60]) by s-opensource.com (Postfix) with ESMTPSA id 6BB92A0E78; Fri, 21 Oct 2016 13:01:14 +0000 (UTC) Date: Fri, 21 Oct 2016 11:01:04 -0200 From: Mauro Carvalho Chehab To: Tiffany Lin Cc: Hans Verkuil , , Rob Herring , Matthias Brugger , Daniel Kurtz , Pawel Osciak , Eddie Huang , Yingjoe Chen , , , , , , Subject: Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Message-ID: <20161021110104.5733240e@vento.lan> In-Reply-To: <1472818800-22558-4-git-send-email-tiffany.lin@mediatek.com> References: <1472818800-22558-1-git-send-email-tiffany.lin@mediatek.com> <1472818800-22558-2-git-send-email-tiffany.lin@mediatek.com> <1472818800-22558-3-git-send-email-tiffany.lin@mediatek.com> <1472818800-22558-4-git-send-email-tiffany.lin@mediatek.com> Organization: Samsung X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Fri, 2 Sep 2016 20:19:54 +0800 Tiffany Lin escreveu: > Add v4l2 layer decoder driver for MT8173 > > Signed-off-by: Tiffany Lin > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc) > +{ > + int ret = 0; > + > + switch (fourcc) { > + case V4L2_PIX_FMT_H264: > + case V4L2_PIX_FMT_VP8: > + default: > + return -EINVAL; > + } Did you ever test this driver? The above code will *always* return -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail! I suspect that what you wanted to do, instead, is: switch (fourcc) { case V4L2_PIX_FMT_H264: case V4L2_PIX_FMT_VP8: break; default: return -EINVAL; Btw, this patch series has also several issues that were pointed by checkpatch. Please *always* run checkpatch when submitting your work. You should take a look at the Kernel documentation about how to submit patches, at: https://mchehab.fedorapeople.org/kernel_docs/process/index.html PS.: this time, I fixed the checkpatch issues for you. So, let me know if the patch below is OK, and I'll merge it at media upstream, assuming that the other patches in this series are ok. diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c index 18182f5676d8..79ca03ac449c 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c @@ -26,14 +26,12 @@ int mtk_vcodec_init_dec_pm(struct mtk_vcodec_dev *mtkdev) { struct device_node *node; struct platform_device *pdev; - struct device *dev; struct mtk_vcodec_pm *pm; int ret = 0; pdev = mtkdev->plat_dev; pm = &mtkdev->pm; pm->mtkdev = mtkdev; - dev = &pdev->dev; node = of_parse_phandle(pdev->dev.of_node, "mediatek,larb", 0); if (!node) { mtk_v4l2_err("of_parse_phandle mediatek,larb fail!"); diff --git a/drivers/media/platform/mtk-vcodec/vdec_drv_if.c b/drivers/media/platform/mtk-vcodec/vdec_drv_if.c index 3cb04ef45144..9813b2ffd5fa 100644 --- a/drivers/media/platform/mtk-vcodec/vdec_drv_if.c +++ b/drivers/media/platform/mtk-vcodec/vdec_drv_if.c @@ -31,6 +31,7 @@ int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc) switch (fourcc) { case V4L2_PIX_FMT_H264: case V4L2_PIX_FMT_VP8: + break; default: return -EINVAL; }