| Message ID | 20161024212250.GA31336@amd (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Pavel Machek <pavel@ucw.cz> [161024 14:24]: > Hi! > > What about something like this? N900 will drain the battery down to > system crash, which is quite uncool. Can't we make that generic and configurable for the voltage somehow? Also, the shutdown voltage can depend on external devices connected. It could be for example 3.3V depending on eMMC on some devices while devices with no eMMC could have it at 3.0V. Regards, Tony
On Mon 2016-10-24 14:29:33, Tony Lindgren wrote: > * Pavel Machek <pavel@ucw.cz> [161024 14:24]: > > Hi! > > > > What about something like this? N900 will drain the battery down to > > system crash, which is quite uncool. > > Can't we make that generic and configurable for the voltage somehow? I was afraid someone would ask :-). Yes, we probably need to create battery object in the device tree, then add properties there. > Also, the shutdown voltage can depend on external devices connected. > It could be for example 3.3V depending on eMMC on some devices while > devices with no eMMC could have it at 3.0V. Actually, I'd like to shutdown at 3.3V or more (like 3.5V), because going below that is pretty mean to the battery. But if I set threshold too high, GSM activity will push it below that for a very short while, and I'll shutdown too soon. Ideas welcome... Pavel
On Monday 24 October 2016 23:41:52 Pavel Machek wrote: > On Mon 2016-10-24 14:29:33, Tony Lindgren wrote: > > Also, the shutdown voltage can depend on external devices > > connected. It could be for example 3.3V depending on eMMC on some > > devices while devices with no eMMC could have it at 3.0V. > > Actually, I'd like to shutdown at 3.3V or more (like 3.5V), because > going below that is pretty mean to the battery. But if I set > threshold too high, GSM activity will push it below that for a very > short while, and I'll shutdown too soon. > > Ideas welcome... bq27x00 has EDVF flag which means that battery is empty. Maemo with bq27x00 driver is configured to issue system shutdown when EDVF is set. Maybe kernel should issue emergency shutdown e.g. after minute or two after EDVF flag is set?
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 0fe278b..8eb2f8f 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -46,6 +46,7 @@ #include <linux/delay.h> #include <linux/platform_device.h> #include <linux/power_supply.h> +#include <linux/reboot.h> #include <linux/slab.h> #include <linux/of.h> @@ -740,6 +741,9 @@ void bq27xxx_battery_update(struct bq27xxx_device_info *di) } EXPORT_SYMBOL_GPL(bq27xxx_battery_update); +static int bq27xxx_battery_protect(struct bq27xxx_device_info *di); + + static void bq27xxx_battery_poll(struct work_struct *work) { struct bq27xxx_device_info *di = @@ -747,6 +751,7 @@ static void bq27xxx_battery_poll(struct work_struct *work) work.work); bq27xxx_battery_update(di); + bq27xxx_battery_protect(di); if (poll_interval > 0) schedule_delayed_work(&di->work, poll_interval * HZ); @@ -958,6 +963,41 @@ static int bq27xxx_battery_get_property(struct power_supply *psy, return ret; } +static int bq27xxx_battery_protect(struct bq27xxx_device_info *di) +{ + union power_supply_propval val; + int mV, mA, mOhm = 430, mVadj; + int res; + + printk(KERN_INFO "Main battery check\n"); + + res = bq27xxx_battery_voltage(di, &val); + if (res) + return res; + + mV = val.intval / 1000; + + if (mV < 2950) { + printk(KERN_ALERT "Main battery below 2.95V, forcing shutdown.\n"); + orderly_poweroff(true); + } + + res = bq27xxx_battery_current(di, &val); + if (res) + return res; + + mA = val.intval / 1000; + mVadj = mV + (mA * mOhm) / 1000; + + if (mVadj < 3150) { + printk(KERN_ALERT "Main battery internal voltage below 3.15, shutdown.\n"); + orderly_poweroff(true); + } + printk(KERN_INFO "Main battery %d mV, internal voltage %d mV\n", + mV, mVadj); + return 0; +} + static void bq27xxx_external_power_changed(struct power_supply *psy) { struct bq27xxx_device_info *di = power_supply_get_drvdata(psy); diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 226b0b4ac..bcdc1f8 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -444,7 +444,7 @@ static void handle_critical_trips(struct thermal_zone_device *tz, if (trip_type == THERMAL_TRIP_CRITICAL) { dev_emerg(&tz->device, - "critical temperature reached(%d C),shutting down\n", + "critical temperature reached(%d C), shutting down\n", tz->temperature / 1000); orderly_poweroff(true); }