diff mbox

ceph: include linux/crush/mapper.h in crush/mapper.c

Message ID 20161028112324.14850-1-tklauser@distanz.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Tobias Klauser Oct. 28, 2016, 11:23 a.m. UTC
Include linux/crush/mapper.h in crush/mapper.c to get the prototypes of
crush_find_rule and crush_do_rule which are defined there. This fixes
the following GCC warnings when building with 'W=1':

  net/ceph/crush/mapper.c:40:5: warning: no previous prototype for ‘crush_find_rule’ [-Wmissing-prototypes]
  net/ceph/crush/mapper.c:793:5: warning: no previous prototype for ‘crush_do_rule’ [-Wmissing-prototypes]

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 net/ceph/crush/mapper.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ilya Dryomov Nov. 7, 2016, 6:38 p.m. UTC | #1
On Fri, Oct 28, 2016 at 1:23 PM, Tobias Klauser <tklauser@distanz.ch> wrote:
> Include linux/crush/mapper.h in crush/mapper.c to get the prototypes of
> crush_find_rule and crush_do_rule which are defined there. This fixes
> the following GCC warnings when building with 'W=1':
>
>   net/ceph/crush/mapper.c:40:5: warning: no previous prototype for ‘crush_find_rule’ [-Wmissing-prototypes]
>   net/ceph/crush/mapper.c:793:5: warning: no previous prototype for ‘crush_do_rule’ [-Wmissing-prototypes]
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  net/ceph/crush/mapper.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
> index a421e905331a..407bd146ba9e 100644
> --- a/net/ceph/crush/mapper.c
> +++ b/net/ceph/crush/mapper.c
> @@ -17,6 +17,7 @@
>  # include <linux/kernel.h>
>  # include <linux/crush/crush.h>
>  # include <linux/crush/hash.h>
> +# include <linux/crush/mapper.h>
>  #else
>  # include "crush_compat.h"
>  # include "crush.h"

Applied.

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
index a421e905331a..407bd146ba9e 100644
--- a/net/ceph/crush/mapper.c
+++ b/net/ceph/crush/mapper.c
@@ -17,6 +17,7 @@ 
 # include <linux/kernel.h>
 # include <linux/crush/crush.h>
 # include <linux/crush/hash.h>
+# include <linux/crush/mapper.h>
 #else
 # include "crush_compat.h"
 # include "crush.h"