| Message ID | 20161107154114.26803-1-shuahkh@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c index f95a6bc..cede397 100644 --- a/drivers/media/i2c/ir-kbd-i2c.c +++ b/drivers/media/i2c/ir-kbd-i2c.c @@ -118,7 +118,7 @@ static int get_key_haup_common(struct IR_i2c *ir, enum rc_type *protocol, *protocol = RC_TYPE_RC6_MCE; dev &= 0x7f; dprintk(1, "ir hauppauge (rc6-mce): t%d vendor=%d dev=%d code=%d\n", - toggle, vendor, dev, code); + *ptoggle, vendor, dev, code); } else { *ptoggle = 0; *protocol = RC_TYPE_RC6_6A_32;
Fix the debug message in get_key_haup_common.isra.4() doesn't print the correct toggle value. Fix it. This shows up as an used uninitialized warn message: drivers/media/i2c/ir-kbd-i2c.c: In function ‘get_key_haup_common.isra.4’: drivers/media/i2c/ir-kbd-i2c.c:62:2: warning: ‘toggle’ may be used uninitialized in this function [-Wmaybe-uninitialized] printk(KERN_DEBUG MODULE_NAME ": " fmt , ## arg) ^~~~~~ drivers/media/i2c/ir-kbd-i2c.c:70:20: note: ‘toggle’ was declared here int start, range, toggle, dev, code, ircode, vendor; ^~~~~~ Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- drivers/media/i2c/ir-kbd-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)