diff mbox

ceph: fix printing wrong return variable in ceph_direct_read_write()

Message ID CAGkCoNJ3ie=5artOKOnNdtpx=gj=jvA26SS2XVzLBg644Zui=A@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Zhi Zhang Nov. 8, 2016, 9:16 a.m. UTC
Fix printing wrong return variable for invalidate_inode_pages2_range
in ceph_direct_read_write().

Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
---
 fs/ceph/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

                flags = CEPH_OSD_FLAG_ORDERSNAP |
                        CEPH_OSD_FLAG_ONDISK |


Regards,
Zhi Zhang (David)
Contact: zhang.david2011@gmail.com
              zhangz.david@outlook.com
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Ilya Dryomov Nov. 8, 2016, 1:48 p.m. UTC | #1
On Tue, Nov 8, 2016 at 10:16 AM, Zhi Zhang <zhang.david2011@gmail.com> wrote:
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
>
> Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
> ---
>  fs/ceph/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
>                                         pos >> PAGE_SHIFT,
>                                         (pos + count) >> PAGE_SHIFT);
>                 if (ret2 < 0)
> -                       dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> +                       dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
>
>                 flags = CEPH_OSD_FLAG_ORDERSNAP |
>                         CEPH_OSD_FLAG_ONDISK |
>

Applied.

(This is mangled, and had to be applied manually.  Check out
Documentation/email-clients.txt in the kernel tree.)

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yan, Zheng Nov. 8, 2016, 2:21 p.m. UTC | #2
> On 8 Nov 2016, at 17:16, Zhi Zhang <zhang.david2011@gmail.com> wrote:
> 
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
> 
> Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
>                                       pos >> PAGE_SHIFT,
>                                       (pos + count) >> PAGE_SHIFT);
>               if (ret2 < 0)
> -                       dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> +                       dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
> 
>               flags = CEPH_OSD_FLAG_ORDERSNAP |
>                       CEPH_OSD_FLAG_ONDISK |
> 
> 

Applied, Thanks

Yan, Zheng

> Regards,
> Zhi Zhang (David)
> Contact: zhang.david2011@gmail.com
>             zhangz.david@outlook.com

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 18630e8..0136195 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -906,7 +906,7 @@  void ceph_sync_write_wait(struct inode *inode)
                                        pos >> PAGE_SHIFT,
                                        (pos + count) >> PAGE_SHIFT);
                if (ret2 < 0)
-                       dout("invalidate_inode_pages2_range returned
%d\n", ret);
+                       dout("invalidate_inode_pages2_range returned
%d\n", ret2);