| Message ID | 20161109161602.2402-8-robert@sixbynine.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 9 November 2016 at 16:15, Robert Bragg <robert@sixbynine.org> wrote: > With v8 of the command parser (where we won't get an EINVAL for an > access violation) this updates the bitmasks test to explicitly confirm > that the command became a NOOP by reading back from where the QW_WRITE > would have otherwise landed. > > Signed-off-by: Robert Bragg <robert@sixbynine.org> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c index 63f4efe..1aa5114 100644 --- a/tests/gem_exec_parse.c +++ b/tests/gem_exec_parse.c @@ -472,10 +472,20 @@ igt_main 0, MI_BATCH_BUFFER_END, }; - exec_batch(fd, handle, - pc, sizeof(pc), - I915_EXEC_RENDER, - -EINVAL); + if (parser_version >= 8) { + /* Expect to read back zero since the command should be + * squashed to a NOOP + */ + exec_batch_patched(fd, handle, + pc, sizeof(pc), + 8, /* patch offset, */ + 0x0); + } else { + exec_batch(fd, handle, + pc, sizeof(pc), + I915_EXEC_RENDER, + -EINVAL); + } } igt_subtest("batch-without-end") {
With v8 of the command parser (where we won't get an EINVAL for an access violation) this updates the bitmasks test to explicitly confirm that the command became a NOOP by reading back from where the QW_WRITE would have otherwise landed. Signed-off-by: Robert Bragg <robert@sixbynine.org> --- tests/gem_exec_parse.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-)