| Message ID | 20161111230552.4221-1-killertofu@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Nov 11 2016 or thereabouts, Jason Gerecke wrote: > The eraser end of the 8K pen available for the MobileStudio Pro has a tool > ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently > recognize this ID, causing it to return BTN_TOOL_PEN rather than > BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro > since, as a HID_GENERIC device, the driver relies on the state of the > HID_DG_INVERT usage instead. It would, however, cause problems if the pen > is used with devices that use the traditional 'wacom_intuos_irq' codepath > instead. > > Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 11 Nov 2016, Jason Gerecke wrote: > The eraser end of the 8K pen available for the MobileStudio Pro has a tool > ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently > recognize this ID, causing it to return BTN_TOOL_PEN rather than > BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro > since, as a HID_GENERIC device, the driver relies on the state of the > HID_DG_INVERT usage instead. It would, however, cause problems if the pen > is used with devices that use the traditional 'wacom_intuos_irq' codepath > instead. Applied, thanks.
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 0723ba8..55857bf 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -645,6 +645,7 @@ static int wacom_intuos_get_tool_type(int tool_id) break; case 0x82a: /* Eraser */ + case 0x84a: case 0x85a: case 0x91a: case 0xd1a:
The eraser end of the 8K pen available for the MobileStudio Pro has a tool ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently recognize this ID, causing it to return BTN_TOOL_PEN rather than BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro since, as a HID_GENERIC device, the driver relies on the state of the HID_DG_INVERT usage instead. It would, however, cause problems if the pen is used with devices that use the traditional 'wacom_intuos_irq' codepath instead. Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com> --- drivers/hid/wacom_wac.c | 1 + 1 file changed, 1 insertion(+)