cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper
diff mbox

Message ID 20161114164216.2657919-1-arnd@arndb.de
State Superseded, archived
Headers show

Commit Message

Arnd Bergmann Nov. 14, 2016, 4:41 p.m. UTC
The newly added function uses two different prototypes depending
on configuration, and one of them does not match the caller:

drivers/cpufreq/intel_pstate.c: In function ‘copy_cpu_funcs’:
drivers/cpufreq/intel_pstate.c:1798:2: error: too few arguments to function ‘intel_pstate_use_acpi_profile’

This changes it to look like the other one.

Fixes: 3bea6a285476 ("cpufreq: intel_pstate: Use cpu load based algorithm for mobile class devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/cpufreq/intel_pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Srinivas Pandruvada Nov. 14, 2016, 5:14 p.m. UTC | #1
On Mon, 2016-11-14 at 17:41 +0100, Arnd Bergmann wrote:
> The newly added function uses two different prototypes depending
> on configuration, and one of them does not match the caller:
> 
> drivers/cpufreq/intel_pstate.c: In function ‘copy_cpu_funcs’:
> drivers/cpufreq/intel_pstate.c:1798:2: error: too few arguments to
> function ‘intel_pstate_use_acpi_profile’
> 
> This changes it to look like the other one.
Sorry about that.

> 
> Fixes: 3bea6a285476 ("cpufreq: intel_pstate: Use cpu load based
> algorithm for mobile class devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 65832f8eacdc..7153cf2d8e11 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1779,7 +1779,7 @@ static void intel_pstate_use_acpi_profile(void)
>  				get_target_pstate_use_cpu_load;
>  }
>  #else
> -static inline void intel_pstate_use_acpi_profile(struct pstate_funcs
> *funcs)
> +static inline void intel_pstate_use_acpi_profile(void)
>  {
>  }
>  #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pandruvada, Srinivas Nov. 14, 2016, 5:53 p.m. UTC | #2
T24gTW9uLCAyMDE2LTExLTE0IGF0IDA5OjE0IC0wODAwLCBTcmluaXZhcyBQYW5kcnV2YWRhIHdy
b3RlOg0KPiBPbiBNb24sIDIwMTYtMTEtMTQgYXQgMTc6NDEgKzAxMDAsIEFybmQgQmVyZ21hbm4g
d3JvdGU6DQo+ID4gDQo+ID4gVGhlIG5ld2x5IGFkZGVkIGZ1bmN0aW9uIHVzZXMgdHdvIGRpZmZl
cmVudCBwcm90b3R5cGVzIGRlcGVuZGluZw0KPiA+IG9uIGNvbmZpZ3VyYXRpb24sIGFuZCBvbmUg
b2YgdGhlbSBkb2VzIG5vdCBtYXRjaCB0aGUgY2FsbGVyOg0KPiA+IA0KPiA+IGRyaXZlcnMvY3B1
ZnJlcS9pbnRlbF9wc3RhdGUuYzogSW4gZnVuY3Rpb24g4oCYY29weV9jcHVfZnVuY3PigJk6DQo+
ID4gZHJpdmVycy9jcHVmcmVxL2ludGVsX3BzdGF0ZS5jOjE3OTg6MjogZXJyb3I6IHRvbyBmZXcg
YXJndW1lbnRzIHRvDQo+ID4gZnVuY3Rpb24g4oCYaW50ZWxfcHN0YXRlX3VzZV9hY3BpX3Byb2Zp
bGXigJkNCj4gPiANCj4gPiBUaGlzIGNoYW5nZXMgaXQgdG8gbG9vayBsaWtlIHRoZSBvdGhlciBv
bmUuDQo+IFNvcnJ5IGFib3V0IHRoYXQuDQoNClNpbmNlIHRoaXMgaXMgYSBjb21waWxlIGlzc3Vl
IGZvciB4ODYgbm9uIEFDUEkgc3lzdGVtcywgd2hpY2ggd2lsbCBiZSBhDQpwcm9ibGVtIGZvciBn
aXQgYmlzZWN0LCBpdCBpcyBiZXR0ZXIgdG8gcmVzdWJtaXQgbXkgcGF0Y2ggd2l0aCB0aGUgZml4
Lg0KDQpUaGFua3MsDQpTcmluaXZhcw0K
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 65832f8eacdc..7153cf2d8e11 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1779,7 +1779,7 @@  static void intel_pstate_use_acpi_profile(void)
 				get_target_pstate_use_cpu_load;
 }
 #else
-static inline void intel_pstate_use_acpi_profile(struct pstate_funcs *funcs)
+static inline void intel_pstate_use_acpi_profile(void)
 {
 }
 #endif