| Message ID | 1479215363-2898-5-git-send-email-eric.auger@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 15, 2016 at 01:09:17PM +0000, Eric Auger wrote: > +static inline struct iommu_resv_region * > +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot) > +{ > + return NULL; > +} > + Will this function be called outside of iommu code? Joerg -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Joerg, On 29/11/2016 17:11, Joerg Roedel wrote: > On Tue, Nov 15, 2016 at 01:09:17PM +0000, Eric Auger wrote: >> +static inline struct iommu_resv_region * >> +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot) >> +{ >> + return NULL; >> +} >> + > > Will this function be called outside of iommu code? No the function is not bound to be called outside of the iommu code. I will remove this. Thanks Eric > > > > Joerg > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 15/11/16 13:09, Eric Auger wrote: > Introduce a new helper serving the purpose to allocate a reserved > region. This will be used in iommu driver implementing reserved > region callbacks. > > Signed-off-by: Eric Auger <eric.auger@redhat.com> > --- > drivers/iommu/iommu.c | 16 ++++++++++++++++ > include/linux/iommu.h | 8 ++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index c7ed334..6ee529f 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1562,6 +1562,22 @@ void iommu_put_resv_regions(struct device *dev, struct list_head *list) > ops->put_resv_regions(dev, list); > } > > +struct iommu_resv_region *iommu_alloc_resv_region(phys_addr_t start, > + size_t length, > + unsigned int prot) > +{ > + struct iommu_resv_region *region; > + > + region = kzalloc(sizeof(*region), GFP_KERNEL); > + if (!region) > + return NULL; > + > + region->start = start; > + region->length = length; > + region->prot = prot; > + return region; > +} I think you need an INIT_LIST_HEAD() in here as well, or CONFIG_DEBUG_LIST might get unhappy about using an uninitialised head later. Robin. > + > /* Request that a device is direct mapped by the IOMMU */ > int iommu_request_dm_for_dev(struct device *dev) > { > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 02cf565..0aea877 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -241,6 +241,8 @@ extern void iommu_set_fault_handler(struct iommu_domain *domain, > extern void iommu_get_resv_regions(struct device *dev, struct list_head *list); > extern void iommu_put_resv_regions(struct device *dev, struct list_head *list); > extern int iommu_request_dm_for_dev(struct device *dev); > +extern struct iommu_resv_region * > +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot); > > extern int iommu_attach_group(struct iommu_domain *domain, > struct iommu_group *group); > @@ -454,6 +456,12 @@ static inline void iommu_put_resv_regions(struct device *dev, > { > } > > +static inline struct iommu_resv_region * > +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot) > +{ > + return NULL; > +} > + > static inline int iommu_request_dm_for_dev(struct device *dev) > { > return -ENODEV; > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index c7ed334..6ee529f 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1562,6 +1562,22 @@ void iommu_put_resv_regions(struct device *dev, struct list_head *list) ops->put_resv_regions(dev, list); } +struct iommu_resv_region *iommu_alloc_resv_region(phys_addr_t start, + size_t length, + unsigned int prot) +{ + struct iommu_resv_region *region; + + region = kzalloc(sizeof(*region), GFP_KERNEL); + if (!region) + return NULL; + + region->start = start; + region->length = length; + region->prot = prot; + return region; +} + /* Request that a device is direct mapped by the IOMMU */ int iommu_request_dm_for_dev(struct device *dev) { diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 02cf565..0aea877 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -241,6 +241,8 @@ extern void iommu_set_fault_handler(struct iommu_domain *domain, extern void iommu_get_resv_regions(struct device *dev, struct list_head *list); extern void iommu_put_resv_regions(struct device *dev, struct list_head *list); extern int iommu_request_dm_for_dev(struct device *dev); +extern struct iommu_resv_region * +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot); extern int iommu_attach_group(struct iommu_domain *domain, struct iommu_group *group); @@ -454,6 +456,12 @@ static inline void iommu_put_resv_regions(struct device *dev, { } +static inline struct iommu_resv_region * +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot) +{ + return NULL; +} + static inline int iommu_request_dm_for_dev(struct device *dev) { return -ENODEV;
Introduce a new helper serving the purpose to allocate a reserved region. This will be used in iommu driver implementing reserved region callbacks. Signed-off-by: Eric Auger <eric.auger@redhat.com> --- drivers/iommu/iommu.c | 16 ++++++++++++++++ include/linux/iommu.h | 8 ++++++++ 2 files changed, 24 insertions(+)