| Message ID | 1479215363-2898-6-git-send-email-eric.auger@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15/11/16 13:09, Eric Auger wrote: > As we introduced IOMMU_RESV_NOMAP and IOMMU_RESV_MSI regions, > let's prevent those new regions from being mapped. > > Signed-off-by: Eric Auger <eric.auger@redhat.com> > --- > drivers/iommu/iommu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 6ee529f..a4530ad 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -343,6 +343,9 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group, > start = ALIGN(entry->start, pg_size); > end = ALIGN(entry->start + entry->length, pg_size); > > + if (entry->prot & IOMMU_RESV_MASK) This seems to be the only place that this mask is used, and frankly I think it's less clear than simply "(IOMMU_RESV_NOMAP | IOMMU_RESV_MSI)" would be, at which point we may as well drop the mask and special value trickery altogether. Plus, per my previous comment, if it were to be "if (entry->type != <direct mapped type>)" instead, that's about as obvious as it can get. Robin. > + continue; > + > for (addr = start; addr < end; addr += pg_size) { > phys_addr_t phys_addr; > > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Robin On 06/12/2016 18:36, Robin Murphy wrote: > On 15/11/16 13:09, Eric Auger wrote: >> As we introduced IOMMU_RESV_NOMAP and IOMMU_RESV_MSI regions, >> let's prevent those new regions from being mapped. >> >> Signed-off-by: Eric Auger <eric.auger@redhat.com> >> --- >> drivers/iommu/iommu.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index 6ee529f..a4530ad 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -343,6 +343,9 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group, >> start = ALIGN(entry->start, pg_size); >> end = ALIGN(entry->start + entry->length, pg_size); >> >> + if (entry->prot & IOMMU_RESV_MASK) > > This seems to be the only place that this mask is used, and frankly I > think it's less clear than simply "(IOMMU_RESV_NOMAP | IOMMU_RESV_MSI)" > would be, at which point we may as well drop the mask and special value > trickery altogether. Plus, per my previous comment, if it were to be "if > (entry->type != <direct mapped type>)" instead, that's about as obvious > as it can get. OK I will add this new type entry in the reserved window struct. thanks Eric > > Robin. > >> + continue; >> + >> for (addr = start; addr < end; addr += pg_size) { >> phys_addr_t phys_addr; >> >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 6ee529f..a4530ad 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -343,6 +343,9 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group, start = ALIGN(entry->start, pg_size); end = ALIGN(entry->start + entry->length, pg_size); + if (entry->prot & IOMMU_RESV_MASK) + continue; + for (addr = start; addr < end; addr += pg_size) { phys_addr_t phys_addr;
As we introduced IOMMU_RESV_NOMAP and IOMMU_RESV_MSI regions, let's prevent those new regions from being mapped. Signed-off-by: Eric Auger <eric.auger@redhat.com> --- drivers/iommu/iommu.c | 3 +++ 1 file changed, 3 insertions(+)