From patchwork Wed Nov 16 01:07:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harinath Nampally X-Patchwork-Id: 9430749 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 12F6F60471 for ; Wed, 16 Nov 2016 01:08:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E826828701 for ; Wed, 16 Nov 2016 01:08:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB1F52877D; Wed, 16 Nov 2016 01:08:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 63AAF28701 for ; Wed, 16 Nov 2016 01:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752106AbcKPBH4 (ORCPT ); Tue, 15 Nov 2016 20:07:56 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:33722 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbcKPBHz (ORCPT ); Tue, 15 Nov 2016 20:07:55 -0500 Received: by mail-it0-f65.google.com with SMTP id c20so4020514itb.0 for ; Tue, 15 Nov 2016 17:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=QJTMj59yrDIFjma59+LkdDSPAXN13wkoT4NoWynr+WU=; b=mCZeW9tha3ClR61A5ijCrSeYYHm9PRiwP5m0HqB2o8lgS/Em6ojVtoay7bnaNW9Qf0 8lUSFsN0Y4SNVm97cTh5lrW1vH0ZGosrw1CGFpfSCS4jwp9QwsFZ2vUwmI9whaepdamm y0qomN8Q2oF0wzSsn/+KmHZmKVgy+WjRyyEeeBQPJGi8MkZlVqov/lwJ5p8+rIgQFILj GZklRdKoORVJb2zejY2tlJxu29LhIfi7CAtAM4RGfQdbrV+t6EYSQy65wyCewFbR1AqH 5qDLThK3E/5H0tlSCyVcrAWJaQX+BFyvET2o+YSlYwQqYssyTDOpqIIZqbKYHODv+frJ KquA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=QJTMj59yrDIFjma59+LkdDSPAXN13wkoT4NoWynr+WU=; b=a9m9E5kiFoMJVO2yTKDKiRTKqNSYPLoVjduqBqIAFrSxyRNCtyLEGxgb0mIrz06kZQ lrKHp8jyT/MMSTYUWa43DP3gsDbi40VpTXZc2NRqIFfO24TE5eOhAp9Io8KvKXFHYZb2 qStM7J8aoktGaa6z2Zg3BKHMpEMP3XvSuvR/4bt3TJjlUVFTw3jDfNrUSNkA96CuwwB7 k7yXgj5wP84nPzQ4acCu1GHZfNLJeHeYmrx8AA4NVB5FFm3aSrZgrIx5c3oeaOUbsEvr ExH3d6QrJjA4T9OuU4fM+8bj+OhVr1CWJ7PhG3edZAPVg8Q0HjiJXeQu+6cPwCGZLwl/ LmTA== X-Gm-Message-State: ABUngvcvrDM184MXxkvzSBzijDAfmwivrG92pVJpOXmK06Jje9E9JlGkMIWYILxaO3o7fA== X-Received: by 10.36.50.78 with SMTP id j75mr5599983ita.58.1479258474629; Tue, 15 Nov 2016 17:07:54 -0800 (PST) Received: from hary-Aspire-X3400G.Belkin (174-84-237-140.res.bhn.net. [174.84.237.140]) by smtp.googlemail.com with ESMTPSA id l3sm2486748iti.3.2016.11.15.17.07.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 15 Nov 2016 17:07:54 -0800 (PST) From: Harinath Nampally To: linux-btrfs@vger.kernel.org Subject: [PATCH] Minor coverity defect fix - CID 1125928 In set_file_xattrs: Dereference of an explicit null value Date: Tue, 15 Nov 2016 20:07:53 -0500 Message-Id: <1479258473-30053-1-git-send-email-harinath922@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP --- cmds-restore.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmds-restore.c b/cmds-restore.c index a8c67a5..6c2ea8a 100644 --- a/cmds-restore.c +++ b/cmds-restore.c @@ -509,6 +509,9 @@ static int set_file_xattrs(struct btrfs_root *root, u64 inode, while (cur < total_len) { len = btrfs_dir_name_len(leaf, di); + if (len == 0) { + goto out; + } if (len > name_len) { free(name); name = (char *) malloc(len + 1);