[2/3] btrfs-progs: test: expand size of test device of fsck-tests 013
diff mbox

Message ID 201611180547.AA00018@WIN-5MHF4RKU941.jp.fujitsu.com
State New
Headers show

Commit Message

Tsutomu Itoh Nov. 18, 2016, 5:47 a.m. UTC
In my test environment, size of /lib/modules/`uname -r`/* is
larger than 1GB, so test data can not copy to testdev.
Therefore we need expand the size of testdev.

# make test-fsck
    [TEST]   fsck-tests.sh
    [TEST/fsck]   013-extent-tree-rebuild
failed: cp -aR /lib/modules/4.9.0-rc5/ /test/btrfs-progs/tests/mnt
test failed for case 013-extent-tree-rebuild
Makefile:272: recipe for target 'test-fsck' failed
make: *** [test-fsck] Error 1
#

Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
---
 tests/fsck-tests/013-extent-tree-rebuild/test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qu Wenruo Nov. 18, 2016, 6:36 a.m. UTC | #1
On 11/18/2016 01:47 PM, Tsutomu Itoh wrote:
> In my test environment, size of /lib/modules/`uname -r`/* is
> larger than 1GB, so test data can not copy to testdev.
> Therefore we need expand the size of testdev.

IMHO the correct fix is to enhance populate_fs() to fill the fs into a 
given size, other than using the unreliable copy.

Thanks,
Qu

>
> # make test-fsck
>     [TEST]   fsck-tests.sh
>     [TEST/fsck]   013-extent-tree-rebuild
> failed: cp -aR /lib/modules/4.9.0-rc5/ /test/btrfs-progs/tests/mnt
> test failed for case 013-extent-tree-rebuild
> Makefile:272: recipe for target 'test-fsck' failed
> make: *** [test-fsck] Error 1
> #
>
> Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
> ---
>  tests/fsck-tests/013-extent-tree-rebuild/test.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/fsck-tests/013-extent-tree-rebuild/test.sh b/tests/fsck-tests/013-extent-tree-rebuild/test.sh
> index f678e29..92c5d04 100755
> --- a/tests/fsck-tests/013-extent-tree-rebuild/test.sh
> +++ b/tests/fsck-tests/013-extent-tree-rebuild/test.sh
> @@ -7,7 +7,7 @@ check_prereq mkfs.btrfs
>  check_prereq btrfs
>
>  setup_root_helper
> -prepare_test_dev 1G
> +prepare_test_dev 2G
>
>  # test whether fsck can rebuild a corrupted extent tree
>  test_extent_tree_rebuild()
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Sterba Nov. 18, 2016, 6:28 p.m. UTC | #2
On Fri, Nov 18, 2016 at 02:36:28PM +0800, Qu Wenruo wrote:
> 
> 
> On 11/18/2016 01:47 PM, Tsutomu Itoh wrote:
> > In my test environment, size of /lib/modules/`uname -r`/* is
> > larger than 1GB, so test data can not copy to testdev.
> > Therefore we need expand the size of testdev.
> 
> IMHO the correct fix is to enhance populate_fs() to fill the fs into a 
> given size, other than using the unreliable copy.

Yeah that would be better, the contents of the modules dir could be
anything, but was enough to use for initial testing.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tsutomu Itoh Nov. 21, 2016, 12:39 a.m. UTC | #3
Hi, Qu and David,

On 2016/11/19 3:28, David Sterba wrote:
> On Fri, Nov 18, 2016 at 02:36:28PM +0800, Qu Wenruo wrote:
>>
>>
>> On 11/18/2016 01:47 PM, Tsutomu Itoh wrote:
>>> In my test environment, size of /lib/modules/`uname -r`/* is
>>> larger than 1GB, so test data can not copy to testdev.
>>> Therefore we need expand the size of testdev.
>>
>> IMHO the correct fix is to enhance populate_fs() to fill the fs into a 
>> given size, other than using the unreliable copy.
> 
> Yeah that would be better, the contents of the modules dir could be
> anything, but was enough to use for initial testing.

Thanks for your comments. I'll post v2 patch.

Thanks,
Tsutomu

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/tests/fsck-tests/013-extent-tree-rebuild/test.sh b/tests/fsck-tests/013-extent-tree-rebuild/test.sh
index f678e29..92c5d04 100755
--- a/tests/fsck-tests/013-extent-tree-rebuild/test.sh
+++ b/tests/fsck-tests/013-extent-tree-rebuild/test.sh
@@ -7,7 +7,7 @@  check_prereq mkfs.btrfs
 check_prereq btrfs
 
 setup_root_helper
-prepare_test_dev 1G
+prepare_test_dev 2G
 
 # test whether fsck can rebuild a corrupted extent tree
 test_extent_tree_rebuild()