| Message ID | 20161118100603.14284-3-david.weinehall@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Nov 18, 2016 at 12:06:02PM +0200, David Weinehall wrote: > In i915_gem_resume(), before calling i915_gem_restore_gtt_mappings(), > we want to take the runtime PM reference; this to allow for later > optimisation. ...to hold the rpm wakelocks for the entire duration instead of many short lived wakelocks around each access to the GGTT. We will take it in i915_gem_resume() as any other GEM operation is likely to require the gT powerwell as well. > Signed-off-by: David Weinehall <david.weinehall@linux.intel.com> > CC: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 7b9f5b99b0f3..35c4ed17b898 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -4229,6 +4229,7 @@ void i915_gem_resume(struct drm_device *dev) WARN_ON(dev_priv->gt.awake); + intel_runtime_pm_get(dev_priv); mutex_lock(&dev->struct_mutex); i915_gem_restore_gtt_mappings(dev_priv); @@ -4239,6 +4240,7 @@ void i915_gem_resume(struct drm_device *dev) dev_priv->gt.resume(dev_priv); mutex_unlock(&dev->struct_mutex); + intel_runtime_pm_put(dev_priv); } void i915_gem_init_swizzling(struct drm_i915_private *dev_priv)
In i915_gem_resume(), before calling i915_gem_restore_gtt_mappings(), we want to take the runtime PM reference; this to allow for later optimisation. Signed-off-by: David Weinehall <david.weinehall@linux.intel.com> CC: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ 1 file changed, 2 insertions(+)