| Message ID | 1480275440-9919-1-git-send-email-erik.stromdahl@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4e322f7db51a52caa3d2c1f795ba26dacdcf8fde |
| Delegated to: | Kalle Valo |
| Headers | show |
Erik Stromdahl <erik.stromdahl@gmail.com> wrote: > There is a typo bug in the current implementation of > ath10k_wmi_tlv_op_gen_pdev_set_rd. > The conformance test limits are not set up properly. > > The two arguments ctl2g and ctl5g were not used at all. > Instead, the regdomain arguments rd2g and rd5g were used > for the ctl settings as well. > > Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com> Patch applied to ath-next branch of ath.git, thanks. 4e322f7db51a ath10k: fix TLV set regdomain command
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 97b536e..f304f66 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1313,8 +1313,8 @@ static int ath10k_wmi_tlv_op_pull_echo_ev(struct ath10k *ar, cmd->regd = __cpu_to_le32(rd); cmd->regd_2ghz = __cpu_to_le32(rd2g); cmd->regd_5ghz = __cpu_to_le32(rd5g); - cmd->conform_limit_2ghz = __cpu_to_le32(rd2g); - cmd->conform_limit_5ghz = __cpu_to_le32(rd5g); + cmd->conform_limit_2ghz = __cpu_to_le32(ctl2g); + cmd->conform_limit_5ghz = __cpu_to_le32(ctl5g); ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev set rd\n"); return skb;
There is a typo bug in the current implementation of ath10k_wmi_tlv_op_gen_pdev_set_rd. The conformance test limits are not set up properly. The two arguments ctl2g and ctl5g were not used at all. Instead, the regdomain arguments rd2g and rd5g were used for the ctl settings as well. Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com> --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)