From patchwork Fri Dec 2 04:43:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shailendra.v@samsung.com X-Patchwork-Id: 9457801 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A42926074E for ; Fri, 2 Dec 2016 04:45:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 92CD92847D for ; Fri, 2 Dec 2016 04:45:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85657284A2; Fri, 2 Dec 2016 04:45:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6BE12847D for ; Fri, 2 Dec 2016 04:45:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998AbcLBEpg (ORCPT ); Thu, 1 Dec 2016 23:45:36 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:37576 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbcLBEpf (ORCPT ); Thu, 1 Dec 2016 23:45:35 -0500 Received: from epcpsbgm1new.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OHJ01TBLJVUAI20@mailout3.samsung.com>; Fri, 02 Dec 2016 13:45:33 +0900 (KST) X-AuditID: cbfee61a-f79916d0000062de-b5-5840fc6dcc3d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 89.FE.25310.D6CF0485; Fri, 2 Dec 2016 13:45:33 +0900 (KST) Received: from localhost.localdomain ([107.108.168.37]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OHJ0099TJVGYYB0@mmp1.samsung.com>; Fri, 02 Dec 2016 13:45:33 +0900 (KST) From: Shailendra Verma To: Mauro Carvalho Chehab , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Sylwester Nawrocki , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] exynos4-is: Clean up file handle in open() error path. Date: Fri, 02 Dec 2016 10:13:05 +0530 Message-id: <1480653785-6713-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t9jAd3cPw4RBrsaZSzevF3DZNH/+DWz xfnzG9gtzja9YbfY9Pgaq8XlXXPYLHo2bGW1mHF+H5PFsk1/mCwOv2lntbg1byabxaJvr5gt /l68xObA67Fz1l12j02rOtk8Ni+p99jSD+T1bVnF6PF5k1wAW5SbTUZqYkpqkUJqXnJ+SmZe uq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMs6emspasIit4v79 5ywNjOtYuxg5OSQETCQ6T8xnh7DFJC7cW8/WxcjFISSwlFFi9exvTBDOT0aJiWu2MYJUsQkY Srzu+wuWEBH4yCzx4fJesHZmARmJfRPbmEBsYQF3ib9HD4E1sAioSnRt3cACYvMCxa+v/cnc xcgBtE5BYs4kmwmM3AsYGVYxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBAf6M6kdjAd3 uR9iFOBgVOLhfWHsECHEmlhWXJl7iFGCg1lJhLfvF1CINyWxsiq1KD++qDQntfgQoynQ/onM UqLJ+cAozCuJNzQxNzE3NrAwt7Q0MVIS522c/SxcSCA9sSQ1OzW1ILUIpo+Jg1OqgVHiY0JS ffhUnnnN7+W0xS49zZ32RPvE9J+PPENqGm74LBIx/sbjb9N74vgpZ7XqFdZSe9VMQvWOneXY GrL1THRQ5UvHLt6nv3JjZr/p3u62+aPXsu8mlb6Cj84z5zH926z/YNniiqqPyye+2HHv+Bqh thmPjwU7lbwvZNeudXz9o8GNP/rW6ntKLMUZiYZazEXFiQDcqchZigIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The File handle is not yet added in the vfd list.So no need to call v4l2_fh_del(&ctx->fh) if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/exynos4-is/fimc-m2m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-m2m.c b/drivers/media/platform/exynos4-is/fimc-m2m.c index 6028e4f..d8724fe 100644 --- a/drivers/media/platform/exynos4-is/fimc-m2m.c +++ b/drivers/media/platform/exynos4-is/fimc-m2m.c @@ -663,8 +663,8 @@ static int fimc_m2m_open(struct file *file) v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); error_c: fimc_ctrls_delete(ctx); -error_fh: v4l2_fh_del(&ctx->fh); +error_fh: v4l2_fh_exit(&ctx->fh); kfree(ctx); unlock: