| Message ID | 20161202204422.21832-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On Fri, Dec 02, 2016 at 09:44:22PM +0100, Wolfram Sang wrote: > COMPILE_TEST triggers problems on 32 bit machines, so limit this driver > to 64BIT for now. This is no loss because the hardware is only available > on 64 bit SoCs anyhow. After we obtained more data from the hardware > engineers, we will refactor the code to be usable with COMPILE_TEST. > Don't you want to fold this one into patch 2 and mention the limitation on that patch's commit log? > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > buildbot reported the problem and seems to be happy now. > > drivers/thermal/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 3912d24a07b10f..edaed1282791bf 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -247,7 +247,7 @@ config RCAR_THERMAL > > config RCAR_GEN3_THERMAL > tristate "Renesas R-Car Gen3 thermal driver" > - depends on ARCH_RENESAS || COMPILE_TEST > + depends on ARCH_RENESAS && 64BIT > depends on HAS_IOMEM > depends on OF > help > -- > 2.10.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 06, 2016 at 04:39:57PM -0800, Eduardo Valentin wrote: > On Fri, Dec 02, 2016 at 09:44:22PM +0100, Wolfram Sang wrote: > > COMPILE_TEST triggers problems on 32 bit machines, so limit this driver > > to 64BIT for now. This is no loss because the hardware is only available > > on 64 bit SoCs anyhow. After we obtained more data from the hardware > > engineers, we will refactor the code to be usable with COMPILE_TEST. > > > > Don't you want to fold this one into patch 2 and mention the limitation > on that patch's commit log? Yeah, will do with V3. Didn't want to resend before the next review.
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 3912d24a07b10f..edaed1282791bf 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -247,7 +247,7 @@ config RCAR_THERMAL config RCAR_GEN3_THERMAL tristate "Renesas R-Car Gen3 thermal driver" - depends on ARCH_RENESAS || COMPILE_TEST + depends on ARCH_RENESAS && 64BIT depends on HAS_IOMEM depends on OF help
COMPILE_TEST triggers problems on 32 bit machines, so limit this driver to 64BIT for now. This is no loss because the hardware is only available on 64 bit SoCs anyhow. After we obtained more data from the hardware engineers, we will refactor the code to be usable with COMPILE_TEST. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- buildbot reported the problem and seems to be happy now. drivers/thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)