Patchwork drm/atomic: doc: remove old comment about nonblocking commits

login
register
mail settings
Submitter Gustavo F. Padovan
Date Dec. 5, 2016, 2:03 p.m.
Message ID <1480946626-30917-1-git-send-email-gustavo@padovan.org>
Download mbox | patch
Permalink /patch/9461023/
State New
Headers show

Comments

Gustavo F. Padovan - Dec. 5, 2016, 2:03 p.m.
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

We now support nonblocking commits on drm_atomic_helper_commit()
so the comment is not valid anymore.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/gpu/drm/drm_atomic_helper.c | 3 ---
 1 file changed, 3 deletions(-)
Daniel Vetter - Dec. 5, 2016, 4:31 p.m.
On Mon, Dec 05, 2016 at 12:03:46PM -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> We now support nonblocking commits on drm_atomic_helper_commit()
> so the comment is not valid anymore.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Oops. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 0b16587..95e2984 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -1226,9 +1226,6 @@ static void commit_work(struct work_struct *work)
>   * function implements nonblocking commits, using
>   * drm_atomic_helper_setup_commit() and related functions.
>   *
> - * Note that right now this function does not support nonblocking commits, hence
> - * driver writers must implement their own version for now.
> - *
>   * Committing the actual hardware state is done through the
>   * ->atomic_commit_tail() callback of the &drm_mode_config_helper_funcs vtable,
>   * or it's default implementation drm_atomic_helper_commit_tail().
> -- 
> 2.5.5
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gustavo F. Padovan - Dec. 6, 2016, 6:37 p.m.
2016-12-05 Daniel Vetter <daniel@ffwll.ch>:

> On Mon, Dec 05, 2016 at 12:03:46PM -0200, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > We now support nonblocking commits on drm_atomic_helper_commit()
> > so the comment is not valid anymore.
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Oops. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  drivers/gpu/drm/drm_atomic_helper.c | 3 ---
> >  1 file changed, 3 deletions(-)

Applied to drm-misc-next. Thanks for reviewing.

Gustavo

Patch

diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 0b16587..95e2984 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -1226,9 +1226,6 @@  static void commit_work(struct work_struct *work)
  * function implements nonblocking commits, using
  * drm_atomic_helper_setup_commit() and related functions.
  *
- * Note that right now this function does not support nonblocking commits, hence
- * driver writers must implement their own version for now.
- *
  * Committing the actual hardware state is done through the
  * ->atomic_commit_tail() callback of the &drm_mode_config_helper_funcs vtable,
  * or it's default implementation drm_atomic_helper_commit_tail().