| Message ID | 20161213175449.24525-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter: > fsl is already fully demidlayered in the probe function, but for > convenience stuck with drm_put_dev. Call the unregister/unref parts > separately, to make sure this driver works correct. > > v2: Rebase. > > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Stefan Agner <stefan@agner.ch> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > index 537ca159ffe5..0b35da73c2b0 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev) > { > struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev); > > - drm_put_dev(fsl_dev->drm); > + drm_dev_unregister(fsl_dev->drm); > + drm_dev_unref(fsl_dev->drm); > clk_disable_unprepare(fsl_dev->clk); > clk_unregister(fsl_dev->pix_clk); >
On Tue, Dec 13, 2016 at 06:57:59PM +0100, Lucas Stach wrote: > Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter: > > fsl is already fully demidlayered in the probe function, but for > > convenience stuck with drm_put_dev. Call the unregister/unref parts > > separately, to make sure this driver works correct. > > > > v2: Rebase. > > > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Stefan Agner <stefan@agner.ch> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Ok, applied this one now too, thanks for your review. -Daniel > > > --- > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > index 537ca159ffe5..0b35da73c2b0 100644 > > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev) > > { > > struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev); > > > > - drm_put_dev(fsl_dev->drm); > > + drm_dev_unregister(fsl_dev->drm); > > + drm_dev_unref(fsl_dev->drm); > > clk_disable_unprepare(fsl_dev->clk); > > clk_unregister(fsl_dev->pix_clk); > > > >
On 2016-12-13 13:26, Daniel Vetter wrote: > On Tue, Dec 13, 2016 at 06:57:59PM +0100, Lucas Stach wrote: >> Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter: >> > fsl is already fully demidlayered in the probe function, but for >> > convenience stuck with drm_put_dev. Call the unregister/unref parts >> > separately, to make sure this driver works correct. >> > >> > v2: Rebase. >> > >> > Cc: Lucas Stach <l.stach@pengutronix.de> >> > Cc: Stefan Agner <stefan@agner.ch> >> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> >> >> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Sorry for the delay. > Ok, applied this one now too, thanks for your review. > -Daniel FWIW, just tested it now and looks good to me Acked-by: Stefan Agner <stefan@agner.ch> -- Stefan > >> >> > --- >> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c >> > index 537ca159ffe5..0b35da73c2b0 100644 >> > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c >> > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c >> > @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev) >> > { >> > struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev); >> > >> > - drm_put_dev(fsl_dev->drm); >> > + drm_dev_unregister(fsl_dev->drm); >> > + drm_dev_unref(fsl_dev->drm); >> > clk_disable_unprepare(fsl_dev->clk); >> > clk_unregister(fsl_dev->pix_clk); >> > >> >>
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index 537ca159ffe5..0b35da73c2b0 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev) { struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev); - drm_put_dev(fsl_dev->drm); + drm_dev_unregister(fsl_dev->drm); + drm_dev_unref(fsl_dev->drm); clk_disable_unprepare(fsl_dev->clk); clk_unregister(fsl_dev->pix_clk);
fsl is already fully demidlayered in the probe function, but for convenience stuck with drm_put_dev. Call the unregister/unref parts separately, to make sure this driver works correct. v2: Rebase. Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Stefan Agner <stefan@agner.ch> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)