Applied "ASoC: da7218: Set DAI output pin high impedance when not in use" to the asoc tree
diff mbox

Message ID E1cHrfo-0006Fo-Rm@debutante
State Not Applicable
Headers show

Commit Message

Mark Brown Dec. 16, 2016, 12:31 p.m. UTC
The patch

   ASoC: da7218: Set DAI output pin high impedance when not in use

has been applied to the asoc tree at


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From ac29a8f41740186aee601de99c729530e37ca77c Mon Sep 17 00:00:00 2001
From: Adam Thomson <>
Date: Fri, 16 Dec 2016 11:05:02 +0000
Subject: [PATCH] ASoC: da7218: Set DAI output pin high impedance when not in

For TDM mode, the I2S data out line can be shared between mutliple
codecs. In this scenario, only the active codec should be using
the line, and all others should be high impedance. However,
currently in the driver this configuration isn't set when capture
is inactive, and the line remains driven.

This patch updates the AIF_OUT widget to set the DAI output pin of
the device as high impedance when not in use.

Signed-off-by: Adam Thomson <>
Signed-off-by: Mark Brown <>
 sound/soc/codecs/da7218.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox

diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
index c69e97654fc6..d256ebf9e309 100644
--- a/sound/soc/codecs/da7218.c
+++ b/sound/soc/codecs/da7218.c
@@ -1634,7 +1634,8 @@  static const struct snd_soc_dapm_widget da7218_dapm_widgets[] = {
 	/* DAI */
-	SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, SND_SOC_NOPM, 0, 0),
+			     DA7218_DAI_OE_SHIFT, DA7218_NO_INVERT),
 	SND_SOC_DAPM_AIF_IN("DAIIN", "Playback", 0, SND_SOC_NOPM, 0, 0),
 	/* Output Mixers */