From patchwork Mon Dec 19 20:10:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 9480709 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 08BF6601C0 for ; Mon, 19 Dec 2016 20:11:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EAE1328471 for ; Mon, 19 Dec 2016 20:11:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DFD5A284E1; Mon, 19 Dec 2016 20:11:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82CA328471 for ; Mon, 19 Dec 2016 20:11:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbcLSULh (ORCPT ); Mon, 19 Dec 2016 15:11:37 -0500 Received: from mail-wj0-f194.google.com ([209.85.210.194]:36609 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752844AbcLSULg (ORCPT ); Mon, 19 Dec 2016 15:11:36 -0500 Received: by mail-wj0-f194.google.com with SMTP id j10so25062261wjb.3 for ; Mon, 19 Dec 2016 12:11:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2MBWiwhogj87IG/ZJZixwIuULeWNsPjd4JTz41D8QUY=; b=D5ATJXVZKqM+mWVtbpM+cAdDvJrjK3StfAZEHdVKo9RY6kTugyvWjBiOq+sLNSRYDr 0m88xTv4/vCy3FHlODxnOZOVLeYPCINHWTd0EeN806wH0WIaKwYzDhmsK3bgzf1XwhJK QZxj56Lq/oZm0YhJAwkInRyQ70LEhWQp3SnxEl+w/vXwwfzAPq8lYU4VHRUbNJzoDA1o 6S4mYpFBP67jg23jGOQCwbWw/JzQkFvo+YpR7A7fI+omi2pEVvfPA8iw15xAN7EUspTI sNGwdPOYeX2L+x/3Cuu3w0S2pg2C0X6Rnt/s9XAbmXYWRBFQ+Srr6sMIaSdLk2TZv48S 9mrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2MBWiwhogj87IG/ZJZixwIuULeWNsPjd4JTz41D8QUY=; b=Hfr/T1JFiQICqR63l+P4qPfDFMGzbZevpxwfRIj4jysPzfRaiAeO8AT7gMPjrac3qr fvTtkYUaQ+OFh5gkGHYjSfzEyKVxd957fqxjURHNKoko9F6CDyw97NScyGB0BDOTjQPq 2tTL81qvDpMObKI6poZ7ScTRNa0VIiF0C7EbrOMHB5WFfLNmQDn1FStcDAL+ZAxQ65t0 YB21+xFZ8L5hes7wWp9LSC95JGuANp0mTyBEqORAw0QsBAhbuiCWgLY8GoKCmxDFnFJF jVpg/jUqEHjs+6ggeLWvQnS8oNL3yLrBd8HNmQV5LaH351uDmPhLZMfw0x/n0ioD3DLV h1qw== X-Gm-Message-State: AIkVDXJ9Bafeotx0QwLnou3sxVuDofy6qTajapv6/cbxIr4Wb7Sqqksgwpf+nkyv4jTckg== X-Received: by 10.194.145.197 with SMTP id sw5mr15150016wjb.156.1482178294550; Mon, 19 Dec 2016 12:11:34 -0800 (PST) Received: from amir-VirtualBox.Home (bzq-79-180-107-203.red.bezeqint.net. [79.180.107.203]) by smtp.gmail.com with ESMTPSA id c81sm18651933wmf.22.2016.12.19.12.11.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Dec 2016 12:11:34 -0800 (PST) From: Amir Goldstein To: Jan Kara , Theodore Ts'o , Dave Chinner Cc: "Darrick J . Wong" , Chris Mason , Boaz Harrosh , Jaegeuk Kim , Ryusuke Konishi , Mark Fasheh , Evgeniy Dushistov , Miklos Szeredi , Al Viro , linux-fsdevel@vger.kernel.org Subject: [RFC][PATCH 02/11] ufs: use fs_umode_to_dtype() helper Date: Mon, 19 Dec 2016 22:10:59 +0200 Message-Id: <1482178268-22883-3-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482178268-22883-1-git-send-email-amir73il@gmail.com> References: <1482178268-22883-1-git-send-email-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP replace switch statement with common lookup table implementation. Signed-off-by: Amir Goldstein --- fs/ufs/util.h | 29 +---------------------------- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/fs/ufs/util.h b/fs/ufs/util.h index b7fbf53..2a853e0 100644 --- a/fs/ufs/util.h +++ b/fs/ufs/util.h @@ -157,34 +157,7 @@ ufs_set_de_type(struct super_block *sb, struct ufs_dir_entry *de, int mode) if ((UFS_SB(sb)->s_flags & UFS_DE_MASK) != UFS_DE_44BSD) return; - /* - * TODO turn this into a table lookup - */ - switch (mode & S_IFMT) { - case S_IFSOCK: - de->d_u.d_44.d_type = DT_SOCK; - break; - case S_IFLNK: - de->d_u.d_44.d_type = DT_LNK; - break; - case S_IFREG: - de->d_u.d_44.d_type = DT_REG; - break; - case S_IFBLK: - de->d_u.d_44.d_type = DT_BLK; - break; - case S_IFDIR: - de->d_u.d_44.d_type = DT_DIR; - break; - case S_IFCHR: - de->d_u.d_44.d_type = DT_CHR; - break; - case S_IFIFO: - de->d_u.d_44.d_type = DT_FIFO; - break; - default: - de->d_u.d_44.d_type = DT_UNKNOWN; - } + de->d_u.d_44.d_type = fs_umode_to_dtype(mode); } static inline u32