| Message ID | 147830456011.26713.11759326361226626805.stgit@birch.djwong.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Nov 04, 2016 at 05:09:20PM -0700, Darrick J. Wong wrote: > The userspace version of _dinode_verify takes a raw inode number > instead of an inode itself. Since neither version actually needs > the inode, port the changes to the kernel. This will also reduce > the libxfs diff noise. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Looks fine, Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/libxfs/xfs_inode_buf.c b/libxfs/xfs_inode_buf.c index 8732359..3f2049b 100644 --- a/libxfs/xfs_inode_buf.c +++ b/libxfs/xfs_inode_buf.c @@ -378,7 +378,7 @@ xfs_log_dinode_to_disk( } } -bool +static bool xfs_dinode_verify( struct xfs_mount *mp, xfs_ino_t ino, diff --git a/libxfs/xfs_inode_buf.h b/libxfs/xfs_inode_buf.h index 99f1821..6848a0a 100644 --- a/libxfs/xfs_inode_buf.h +++ b/libxfs/xfs_inode_buf.h @@ -73,8 +73,6 @@ void xfs_inode_to_disk(struct xfs_inode *ip, struct xfs_dinode *to, void xfs_inode_from_disk(struct xfs_inode *ip, struct xfs_dinode *from); void xfs_log_dinode_to_disk(struct xfs_log_dinode *from, struct xfs_dinode *to); -bool xfs_dinode_verify(struct xfs_mount *mp, xfs_ino_t ino, - struct xfs_dinode *dip); bool xfs_dinode_good_version(struct xfs_mount *mp, __u8 version);
The userspace version of _dinode_verify takes a raw inode number instead of an inode itself. Since neither version actually needs the inode, port the changes to the kernel. This will also reduce the libxfs diff noise. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- libxfs/xfs_inode_buf.c | 2 +- libxfs/xfs_inode_buf.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html