From patchwork Fri Dec 23 19:27:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 9487663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 247EF601D7 for ; Fri, 23 Dec 2016 19:28:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1883026212 for ; Fri, 23 Dec 2016 19:28:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0C04126538; Fri, 23 Dec 2016 19:28:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33CF126212 for ; Fri, 23 Dec 2016 19:28:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932305AbcLWT2I (ORCPT ); Fri, 23 Dec 2016 14:28:08 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:5940 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbcLWT2D (ORCPT ); Fri, 23 Dec 2016 14:28:03 -0500 X-IronPort-AV: E=Sophos;i="5.33,395,1477954800"; d="scan'208";a="251430500" Received: from 198.67.28.109.rev.sfr.net (HELO [192.168.1.69]) ([109.28.67.198]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2016 20:27:14 +0100 Date: Fri, 23 Dec 2016 20:27:13 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: andros@netapp.com cc: anna.schumaker@netapp.com, bfieldses.org@netapp.com, linux-nfs@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] fix odd_ptr_err.cocci warnings (fwd) Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Andy Adamson Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- I haven't looked at the context in detail, but the change looks plausible. url: https://github.com/0day-ci/linux/commits/andros-netapp-com/RFC-RPCSEC_GSS-Version-3-prototype-Full-Mode-MAC/20161224-014029 base: git://linux-nfs.org/~bfields/linux.git nfsd-next :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago auth_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -1939,7 +1939,7 @@ gss3_create_label(struct rpc_cred *cred) g3a = gss3_alloc_init_assertion(&cres); if (IS_ERR(g3a)) { - ret = PTR_ERR(task); + ret = PTR_ERR(g3a); goto out_free_assert; } gss3_insert_assertion(&ctx->gc_alist, g3a);