From patchwork Sat Dec 24 18:50:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriele Mazzotta X-Patchwork-Id: 9488109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C2F70604DE for ; Sat, 24 Dec 2016 19:10:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EFE920649 for ; Sat, 24 Dec 2016 19:10:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8029320952; Sat, 24 Dec 2016 19:10:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFB2E20649 for ; Sat, 24 Dec 2016 19:09:59 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 15B11266872; Sat, 24 Dec 2016 20:09:58 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 751EB26661C; Sat, 24 Dec 2016 20:07:39 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id EB001265A82; Sat, 24 Dec 2016 19:50:10 +0100 (CET) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by alsa0.perex.cz (Postfix) with ESMTP id 226E4265A82 for ; Sat, 24 Dec 2016 19:50:09 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id c85so9180981wmi.1 for ; Sat, 24 Dec 2016 10:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pjrKrjzmFmHXyqVIhc1c4h0F6DLZ77Gis4EAdpYZ7JA=; b=Kk2oLHBUYysFBqNayzBfyo6TDgE8E10EmL3oozHPbxPz8SXkNlTzNuc+BM8AHVKDgn bZCHg7ODb4I4COD2a1wNsqBFWoB1VavpWeVaxuRkgRbMPAY2gQrn55mmwO0EoMKnBPyN E0O3xHknWSXvwvkPIcENrOfpWkZXN6d/M/YqPeBH61nMbkuECO44yK8egILSDTpfd4Ub 6YpLOpN3N5EbS2na4NK2UwaL9F12u6vFxrIRoRtmI8WBz74OO+Yw8vevnkL2Wy0CWjIg Bm5Va56qWN2oUAuh9gJRgYNcvr2YcfFnfJ4gWZEHxULDL5hQC+lJIKkhQMOltrqDgUIq VVmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pjrKrjzmFmHXyqVIhc1c4h0F6DLZ77Gis4EAdpYZ7JA=; b=EqzOAM1pOqO5QXRYHQGaTtt17qxrblEttxVpP70BE2IGzP4kZ+MLA/TajQrXNvoIY1 Q/S9cz/w5UXeZ/Q7x65xEUsvjd8xYw2R9GlTNyZq3m/q2hlzPBEgQxBGlqQe8b2+WDrp Hie8zAeUBSCS6BujQsSR1SRY9GKkjCsBd0opUyX51BNcz5sV8JKIvtfdFUTuoQywRC8i r1xSWyeZPtp9TySwG60pg7yKQhFoW+sYIBD/y8mNsmLZV0LDicfIZtTrdfmfcK/C+BSv EXCsRK/t4j6F9S7hfYsLHvQJNU0mtkte4QBx8hNmXHiUOKQds1dHd/UP76NPqU5/aHwb oXuw== X-Gm-Message-State: AIkVDXJki5sffQ8VHbrS+QZZ2774xMw/eKKvOsXwUaRWZx5VjZX4PzUwLHdyajdkUDBwIg== X-Received: by 10.28.143.20 with SMTP id r20mr19536474wmd.2.1482605408821; Sat, 24 Dec 2016 10:50:08 -0800 (PST) Received: from xps13.homenet (2-230-197-194.ip203.fastwebnet.it. [2.230.197.194]) by smtp.gmail.com with ESMTPSA id e188sm43288374wma.21.2016.12.24.10.50.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Dec 2016 10:50:08 -0800 (PST) From: Gabriele Mazzotta To: perex@perex.cz, tiwai@suse.com Date: Sat, 24 Dec 2016 19:50:01 +0100 Message-Id: <20161224185001.26824-2-gabriele.mzt@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20161224185001.26824-1-gabriele.mzt@gmail.com> References: <20161224185001.26824-1-gabriele.mzt@gmail.com> Cc: alsa-devel@alsa-project.org, Gabriele Mazzotta , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 2/2] ALSA: hda - Fix click noises on Samsung Ativ Book 8 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The Samsung Ativ Book 8 makes a loud click noise on boot, shutdown and when the audio card enters or exits power saving states. All these noises disappear applying ALC269_FIXUP_NO_SHUTUP. In addition to that, fix the loud click noise that the laptop makes when inserting or removing the headphone jack by automuting via amp instead of pinctl. Signed-off-by: Gabriele Mazzotta --- sound/pci/hda/patch_realtek.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d30cc49512e4..00df12b6695a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4856,6 +4856,7 @@ enum { ALC292_FIXUP_TPT460, ALC298_FIXUP_SPK_VOLUME, ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER, + ALC269_FIXUP_ATIV_BOOK_8, }; static const struct hda_fixup alc269_fixups[] = { @@ -5528,6 +5529,12 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE }, + [ALC269_FIXUP_ATIV_BOOK_8] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_auto_mute_via_amp, + .chained = true, + .chain_id = ALC269_FIXUP_NO_SHUTUP + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -5664,6 +5671,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x10cf, 0x1757, "Lifebook E752", ALC269_FIXUP_LIFEBOOK_HP_PIN), SND_PCI_QUIRK(0x10cf, 0x1845, "Lifebook U904", ALC269_FIXUP_LIFEBOOK_EXTMIC), SND_PCI_QUIRK(0x144d, 0xc109, "Samsung Ativ book 9 (NP900X3G)", ALC269_FIXUP_INV_DMIC), + SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8), SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),