| Message ID | 1482835765-12044-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/27/2016 04:19 PM, Daniel Vetter wrote: > This is the deprecated function for when you embedded the framebuffer > somewhere else (which breaks refcounting). But msm is using > drm_framebuffer_remove and a free-standing fb, so this is rendundant. > > Cc: Rob Clark <robdclark@gmail.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Archit Taneja <architt@codeaurora.org> > --- > drivers/gpu/drm/msm/msm_fbdev.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c > index 5d68ab362d75..f8a587eac6b8 100644 > --- a/drivers/gpu/drm/msm/msm_fbdev.c > +++ b/drivers/gpu/drm/msm/msm_fbdev.c > @@ -174,10 +174,8 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, > fail: > > if (ret) { > - if (fb) { > - drm_framebuffer_unregister_private(fb); > + if (fb) > drm_framebuffer_remove(fb); > - } > } > > return ret; > @@ -247,7 +245,6 @@ void msm_fbdev_free(struct drm_device *dev) > /* this will free the backing object */ > if (fbdev->fb) { > msm_gem_put_vaddr(fbdev->bo); > - drm_framebuffer_unregister_private(fbdev->fb); > drm_framebuffer_remove(fbdev->fb); > } > >
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index 5d68ab362d75..f8a587eac6b8 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -174,10 +174,8 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, fail: if (ret) { - if (fb) { - drm_framebuffer_unregister_private(fb); + if (fb) drm_framebuffer_remove(fb); - } } return ret; @@ -247,7 +245,6 @@ void msm_fbdev_free(struct drm_device *dev) /* this will free the backing object */ if (fbdev->fb) { msm_gem_put_vaddr(fbdev->bo); - drm_framebuffer_unregister_private(fbdev->fb); drm_framebuffer_remove(fbdev->fb); }
This is the deprecated function for when you embedded the framebuffer somewhere else (which breaks refcounting). But msm is using drm_framebuffer_remove and a free-standing fb, so this is rendundant. Cc: Rob Clark <robdclark@gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/msm/msm_fbdev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)