alsactl: Remove standard output definition in systemd unit
diff mbox

Message ID 1482878852.3735.21.camel@users.sourceforge.net
State New
Headers show

Commit Message

Paul Menzel Dec. 27, 2016, 10:47 p.m. UTC
Date: Tue, 8 Jul 2014 07:23:06 +0000

`/lib/systemd/system/alsa-restore.service` specifies
`StandardOutput=syslog`. This overrides the `DefaultStandardOutput`
setting from `/etc/systemd/system.conf`, which the system administrator
can use to specify how output gets logged. In particular, the sysadmin
may want output to go to the journal, or to syslog, or nowhere at all [1].

This patch removes the definition entirely, so the units can use the
system default.

Upstream the patch from the Debian package [2].

[1] https://bugs.debian.org/741123
    "systemd services should not use StandardOutput=syslog; should rely
     on DefaultStandardOutput"
[2] https://sources.debian.net/src/alsa-utils/1.1.2-1/debian/patches/systemd_standardoutput.patch/

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Jordi Mallach <jordi@debian.org>
---
 alsactl/alsa-restore.service.in | 1 -
 1 file changed, 1 deletion(-)

Comments

Takashi Iwai Dec. 28, 2016, 4:09 p.m. UTC | #1
On Tue, 27 Dec 2016 23:47:32 +0100,
Paul Menzel wrote:
> 
> Date: Tue, 8 Jul 2014 07:23:06 +0000
> 
> `/lib/systemd/system/alsa-restore.service` specifies
> `StandardOutput=syslog`. This overrides the `DefaultStandardOutput`
> setting from `/etc/systemd/system.conf`, which the system administrator
> can use to specify how output gets logged. In particular, the sysadmin
> may want output to go to the journal, or to syslog, or nowhere at all [1].
> 
> This patch removes the definition entirely, so the units can use the
> system default.
> 
> Upstream the patch from the Debian package [2].
> 
> [1] https://bugs.debian.org/741123
>     "systemd services should not use StandardOutput=syslog; should rely
>      on DefaultStandardOutput"
> [2] https://sources.debian.net/src/alsa-utils/1.1.2-1/debian/patches/systemd_standardoutput.patch/
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> CC: Jordi Mallach <jordi@debian.org>

Applied, thanks.


Takashi

Patch
diff mbox

diff --git a/alsactl/alsa-restore.service.in b/alsactl/alsa-restore.service.in
index f3cd86b..c092c2f 100644
--- a/alsactl/alsa-restore.service.in
+++ b/alsactl/alsa-restore.service.in
@@ -15,4 +15,3 @@  Type=oneshot
 RemainAfterExit=true
 ExecStart=-@sbindir@/alsactl restore
 ExecStop=-@sbindir@/alsactl store
-StandardOutput=syslog