[3/6] alsa-lib: pcm:dshare enable silence
diff mbox

Message ID 1483079351-28905-1-git-send-email-sutar.mounesh@gmail.com
State New
Headers show

Commit Message

sutar.mounesh@gmail.com Dec. 30, 2016, 6:29 a.m. UTC
From: Alexander Jahn <ajahn@de.adit-jv.com>

This issue depends on system load - if the process using dshare is scheduled
fast enough, then there is no noise. A delay of e.g >~2ms produces hearable noise.

Reproduction with instrumented aplay(sleep every 100th period for a given time):
During the sleep time of 2000000us (2s) the hardware plays old samples in a
loop before xrun is detected and recovered after the sleep.
This is resolved by placing it in silence, in case of dshare plugin.

Signed-off-by: Alexander Jahn <ajahn@de.adit-jv.com>
Signed-off-by: Andreas Pape <apape@de.adit-jv.com>

Comments

Takashi Iwai Jan. 2, 2017, 1:55 p.m. UTC | #1
On Fri, 30 Dec 2016 07:29:11 +0100,
sutar.mounesh@gmail.com wrote:
> 
> From: Alexander Jahn <ajahn@de.adit-jv.com>
> 
> This issue depends on system load - if the process using dshare is scheduled
> fast enough, then there is no noise. A delay of e.g >~2ms produces hearable noise.
> 
> Reproduction with instrumented aplay(sleep every 100th period for a given time):
> During the sleep time of 2000000us (2s) the hardware plays old samples in a
> loop before xrun is detected and recovered after the sleep.
> This is resolved by placing it in silence, in case of dshare plugin.
> 
> Signed-off-by: Alexander Jahn <ajahn@de.adit-jv.com>
> Signed-off-by: Andreas Pape <apape@de.adit-jv.com>

Applied this one with a slight coding style fix.  Thanks.


Takashi


> 
> diff --git a/src/pcm/pcm_direct.c b/src/pcm/pcm_direct.c
> index 4234d66..779845c 100644
> --- a/src/pcm/pcm_direct.c
> +++ b/src/pcm/pcm_direct.c
> @@ -1240,7 +1240,7 @@ int snd_pcm_direct_initialize_slave(snd_pcm_direct_t *dmix, snd_pcm_t *spcm, str
>  		return ret;
>  	}
>  
> -	if (dmix->type != SND_PCM_TYPE_DMIX)
> +	if ((dmix->type != SND_PCM_TYPE_DMIX)&&(dmix->type != SND_PCM_TYPE_DSHARE))
>  		goto __skip_silencing;
>  
>  	ret = snd_pcm_sw_params_set_silence_threshold(spcm, &sw_params, 0);
> -- 
> 1.7.9.5
>

Patch
diff mbox

diff --git a/src/pcm/pcm_direct.c b/src/pcm/pcm_direct.c
index 4234d66..779845c 100644
--- a/src/pcm/pcm_direct.c
+++ b/src/pcm/pcm_direct.c
@@ -1240,7 +1240,7 @@  int snd_pcm_direct_initialize_slave(snd_pcm_direct_t *dmix, snd_pcm_t *spcm, str
 		return ret;
 	}
 
-	if (dmix->type != SND_PCM_TYPE_DMIX)
+	if ((dmix->type != SND_PCM_TYPE_DMIX)&&(dmix->type != SND_PCM_TYPE_DSHARE))
 		goto __skip_silencing;
 
 	ret = snd_pcm_sw_params_set_silence_threshold(spcm, &sw_params, 0);