From patchwork Sun Jan 8 16:41:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 9503517 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 05F396075C for ; Sun, 8 Jan 2017 16:41:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E67A92793B for ; Sun, 8 Jan 2017 16:41:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D814F27F88; Sun, 8 Jan 2017 16:41:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F29627FB2 for ; Sun, 8 Jan 2017 16:41:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756568AbdAHQl0 (ORCPT ); Sun, 8 Jan 2017 11:41:26 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34181 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753945AbdAHQlL (ORCPT ); Sun, 8 Jan 2017 11:41:11 -0500 Received: by mail-lf0-f47.google.com with SMTP id v186so27263574lfa.1 for ; Sun, 08 Jan 2017 08:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v5z2Bw+xKD41Y9hpMWfbvdiaEjwGsbyMtLrJ/nFWLqA=; b=SCjLLK20QL6u17gd87gzNTNDrtYVX3TxUfv859dKhfo8VLXPHEz6nYrO9uCksBNBmT 2mK0629tzPpQpP3/HrjU+jaUrC48Xyl4EG/+dYe1hli03Xq478fUVxR+Y/9eZF12jMiD jRB8Na/LntNjPjuTkA5WriM+C8+RiFal6lNFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v5z2Bw+xKD41Y9hpMWfbvdiaEjwGsbyMtLrJ/nFWLqA=; b=TbCKpuuGDTHYgY/tcYh3X33bpQf3b0RdxoglHOIX8Rv8zHqSVmE5zv/Z+vlgtVJ5zr koVjWA+XRM2NMqWPAeZOXUJB89oR1plWnkHVma6Nc5klSQsk+Gdd9p3uf3eFkDuqMOMq Tqq+eQYnG+ABhlWXcggB80U+nkvPwg1qZpggAXIAKIG085onqyJa/Yk0s2cq51CjWPsW /7jPbJeUH8h0TPOEvSo/44kwyH7pS07zxshnwaji9nL2jemf8EriVGTPwtXrVENlB5Je zSImfgwXGBFsKvUnW8xDlH6bizy3CapqiAVxAKvRWjCZ+LCdR/CtCInIJtXSL1NjZsVf eWIA== X-Gm-Message-State: AIkVDXLOMiTTrTZDUt2aNNWlQJqvYRkFeLA+suaPmB+2ISFukjGthADOs2p5uDfmFROrhsO0 X-Received: by 10.46.14.26 with SMTP id 26mr29316856ljo.24.1483893669420; Sun, 08 Jan 2017 08:41:09 -0800 (PST) Received: from localhost.localdomain (183-224-132-95.pool.ukrtel.net. [95.132.224.183]) by smtp.gmail.com with ESMTPSA id c77sm20196895lfg.29.2017.01.08.08.41.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Jan 2017 08:41:08 -0800 (PST) From: Ivan Khoronzhuk To: netdev@vger.kernel.org, mugunthanvnm@ti.com Cc: linux-omap@vger.kernel.org, grygorii.strashko@ti.com, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH 2/4] net: ethernet: ti: cpsw: don't disable interrupts in ndo_open Date: Sun, 8 Jan 2017 18:41:01 +0200 Message-Id: <1483893663-15673-3-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1483893663-15673-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1483893663-15673-1-git-send-email-ivan.khoronzhuk@linaro.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If any interface is running the interrupts are disabled anyway. It make sense to disable interrupts if any of interfaces is running, but in this place, obviously, it didn't have any effect. So, no need in redundant check and interrupt disable. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index d261024..40d7fc9 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1480,8 +1480,6 @@ static int cpsw_ndo_open(struct net_device *ndev) return ret; } - if (!cpsw_common_res_usage_state(cpsw)) - cpsw_intr_disable(cpsw); netif_carrier_off(ndev); /* Notify the stack of the actual queue counts. */