| Message ID | 20170113161452.14313-2-romain.perier@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Romain,
[auto build test WARNING on rockchip/for-next]
[also build test WARNING on v4.10-rc3 next-20170113]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Romain-Perier/Add-support-for-es8388-on-the-rock2/20170115-095611
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=alpha
All warnings (new ones prefixed by >>):
>> sound/soc/codecs/es8328-i2c.c:22:14: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
{ "es8328", "es8388", 0 },
^~~~~~~~
sound/soc/codecs/es8328-i2c.c:22:14: note: (near initialization for 'es8328_id[0].driver_data')
>> sound/soc/codecs/es8328-i2c.c:22:24: warning: excess elements in struct initializer
{ "es8328", "es8388", 0 },
^
sound/soc/codecs/es8328-i2c.c:22:24: note: (near initialization for 'es8328_id[0]')
vim +22 sound/soc/codecs/es8328-i2c.c
6 * Author: Sean Cross <xobs@kosagi.com>
7 *
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License version 2 as
10 * published by the Free Software Foundation.
11 */
12
13 #include <linux/module.h>
14 #include <linux/i2c.h>
15 #include <linux/regmap.h>
16
17 #include <sound/soc.h>
18
19 #include "es8328.h"
20
21 static const struct i2c_device_id es8328_id[] = {
> 22 { "es8328", "es8388", 0 },
23 { }
24 };
25 MODULE_DEVICE_TABLE(i2c, es8328_id);
26
27 static const struct of_device_id es8328_of_match[] = {
28 { .compatible = "everest,es8328", },
29 { .compatible = "everest,es8388", },
30 { }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Heiko, Le 13/01/2017 à 17:43, Heiko Stuebner a écrit : > Hi Romain, > > Am Freitag, 13. Januar 2017, 17:14:49 CET schrieb Romain Perier: >> This commit adds a compatible string for everest,es8388. This is >> an audio codec that is compatible with es8328. >> >> Signed-off-by: Romain Perier <romain.perier@collabora.com> >> --- >> Documentation/devicetree/bindings/sound/es8328.txt | 2 +- >> sound/soc/codecs/es8328-i2c.c | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/es8328.txt >> b/Documentation/devicetree/bindings/sound/es8328.txt index 30ea8a3..33fbf05 >> 100644 >> --- a/Documentation/devicetree/bindings/sound/es8328.txt >> +++ b/Documentation/devicetree/bindings/sound/es8328.txt >> @@ -4,7 +4,7 @@ This device supports both I2C and SPI. >> >> Required properties: >> >> - - compatible : "everest,es8328" >> + - compatible : Should be "everest,es8328" or "everest,es8388" >> - DVDD-supply : Regulator providing digital core supply voltage 1.8 - >> 3.6V - AVDD-supply : Regulator providing analog supply voltage 3.3V >> - PVDD-supply : Regulator providing digital IO supply voltage 1.8 - 3.6V >> diff --git a/sound/soc/codecs/es8328-i2c.c b/sound/soc/codecs/es8328-i2c.c >> index 2d05b5d..09ae67f 100644 >> --- a/sound/soc/codecs/es8328-i2c.c >> +++ b/sound/soc/codecs/es8328-i2c.c >> @@ -19,13 +19,14 @@ >> #include "es8328.h" >> >> static const struct i2c_device_id es8328_id[] = { >> - { "es8328", 0 }, >> + { "es8328", "es8388", 0 }, > that looks strange or I'm just blind. > > struct i2c_device_id { > char name[I2C_NAME_SIZE]; > kernel_ulong_t driver_data; /* Data private to the driver */ > }; > > so shouldn't this be > > static const struct i2c_device_id es8328_id[] = { > { "es8328", 0 }, > + { "es8388", 0 }, > > instead? Good catch! thanks, Romain
diff --git a/Documentation/devicetree/bindings/sound/es8328.txt b/Documentation/devicetree/bindings/sound/es8328.txt index 30ea8a3..33fbf05 100644 --- a/Documentation/devicetree/bindings/sound/es8328.txt +++ b/Documentation/devicetree/bindings/sound/es8328.txt @@ -4,7 +4,7 @@ This device supports both I2C and SPI. Required properties: - - compatible : "everest,es8328" + - compatible : Should be "everest,es8328" or "everest,es8388" - DVDD-supply : Regulator providing digital core supply voltage 1.8 - 3.6V - AVDD-supply : Regulator providing analog supply voltage 3.3V - PVDD-supply : Regulator providing digital IO supply voltage 1.8 - 3.6V diff --git a/sound/soc/codecs/es8328-i2c.c b/sound/soc/codecs/es8328-i2c.c index 2d05b5d..09ae67f 100644 --- a/sound/soc/codecs/es8328-i2c.c +++ b/sound/soc/codecs/es8328-i2c.c @@ -19,13 +19,14 @@ #include "es8328.h" static const struct i2c_device_id es8328_id[] = { - { "es8328", 0 }, + { "es8328", "es8388", 0 }, { } }; MODULE_DEVICE_TABLE(i2c, es8328_id); static const struct of_device_id es8328_of_match[] = { { .compatible = "everest,es8328", }, + { .compatible = "everest,es8388", }, { } }; MODULE_DEVICE_TABLE(of, es8328_of_match);
This commit adds a compatible string for everest,es8388. This is an audio codec that is compatible with es8328. Signed-off-by: Romain Perier <romain.perier@collabora.com> --- Documentation/devicetree/bindings/sound/es8328.txt | 2 +- sound/soc/codecs/es8328-i2c.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)