From patchwork Mon Jan 16 13:25:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9519293 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F09AA60209 for ; Mon, 16 Jan 2017 18:09:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF86A28443 for ; Mon, 16 Jan 2017 18:09:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2A10284D5; Mon, 16 Jan 2017 18:09:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D2A128443 for ; Mon, 16 Jan 2017 18:09:38 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4F11B2670FA; Mon, 16 Jan 2017 19:09:37 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id AE89F2670FA; Mon, 16 Jan 2017 19:07:18 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 947E32670B8; Mon, 16 Jan 2017 14:26:07 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by alsa0.perex.cz (Postfix) with ESMTP id EBC4A267058 for ; Mon, 16 Jan 2017 14:26:05 +0100 (CET) Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MVV8g-1bvY6r08YY-00Yl5t; Mon, 16 Jan 2017 14:25:59 +0100 From: Arnd Bergmann To: Jaroslav Kysela , Takashi Iwai Date: Mon, 16 Jan 2017 14:25:47 +0100 Message-Id: <20170116132557.2178801-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:5a/cIw+KczPQlzqJzmcg/USDlZXFsvO68/zSOrlnBP89INmJaP6 AbZ4M5gj4v4Yb8GfjN3z9Y4eNpMK21HwBJNCgAxrDSbZb3O4QLhYdLfarHg6lNxs5rEW+lS wxAhDxjYp3yUj/ogRWK6SL9v+urFihASXLn4EnMQ76wOjV97+azRPAD9tuLkDs+3TSOI3vT qztUJhq5ngRkwIdDrRHjw== X-UI-Out-Filterresults: notjunk:1; V01:K0:Y/RJH/ewfKo=:dyXNjNihEs8hn1xBJd05DI spy7uoSfxKbWZN3oKG/+vtWinIE5CINOPcaAtWUXKuWhQsqMQFYtehn6j1qJBTxmnBvh1x/0T mmzVUVREdF6jUb3bvx9Pbt863V9VoYnc6KFA6cSlOT8e9tXTCwd3CSVx/9jibL45wPt0yYVBJ cd9V2j8+ScfvopyiVwNH5MrUrx/bmptOslWAPCvjF2w23p38LOf4RP61bEVskbYXsAF8HEFSd vse6dOZwX6pKoGb3/pL97aPD/u17kH80h0dUTJ437Xt6Y6MvKGecM4LhC00304IOPWvudrF35 +nvKkfLivlVZamDXBBSmVqoDgu66vj4jNmeLq8j/hCGbhdOs13YRFmKvo+E3TI3eZhytO5Ut/ xIDXTo2y5Cu8KICce9WZfDlVJy86MjrvnoOEf++BKi50KVFruQz2RjQepKORdO7n51sFrmDj1 nYqmUgCkeJ6LFjto7kiVzFGXtpH88JjkmDgRVRrgycQE2JPYTvFadFNNmr3orlS8N9bZynrET MGKpf5boPJEC/aoxV2EgMTBPMlE6fqy6siGsp4VXN30iMAS+2OU40uXJWMD4Jcxtbsik5b1fn 4oI8Mq1XLHk7Ci2YqIHU3co7ahClcaARxkApL4vK04gO0BpP0jrLoX4wZUMCOclHgYefuYS7l LHleEjRvIqUJFJsf9/BNxUITVD7U3K8XL6G7AhdA30v1KACXNfr1ugvf4U49UC8/5dCM= Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [alsa-devel] [PATCH v2] ALSA: mips: avoid potential uninitialized variable use X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP MIPS allmodconfig results in this warning: sound/mips/hal2.c: In function 'hal2_gain_get': sound/mips/hal2.c:224:35: error: 'r' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/mips/hal2.c:223:35: error: 'l' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/mips/hal2.c: In function 'hal2_gain_put': sound/mips/hal2.c:260:13: error: 'new' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/mips/hal2.c:260:13: error: 'old' may be used uninitialized in this function [-Werror=maybe-uninitialized] Returning an error for all unexpected cases shuts up the warning Signed-off-by: Arnd Bergmann --- v2: return an error instead trying to handle gracefully --- sound/mips/hal2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c index ede449f0b50d..0af4f7a9b3e7 100644 --- a/sound/mips/hal2.c +++ b/sound/mips/hal2.c @@ -219,6 +219,9 @@ static int hal2_gain_get(struct snd_kcontrol *kcontrol, l = (tmp >> H2I_C2_L_GAIN_SHIFT) & 15; r = (tmp >> H2I_C2_R_GAIN_SHIFT) & 15; break; + default: + l = 0; + r = 0; } ucontrol->value.integer.value[0] = l; ucontrol->value.integer.value[1] = r; @@ -256,6 +259,9 @@ static int hal2_gain_put(struct snd_kcontrol *kcontrol, new |= (r << H2I_C2_R_GAIN_SHIFT); hal2_i_write32(hal2, H2I_ADC_C2, new); break; + default: + new = 0; + old = 0; } return old != new; }