| Message ID | 20170117143547.30488-3-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2017-01-17 at 15:35 +0100, Benjamin Tissoires wrote: > From: Bastien Nocera <hadess@hadess.net> > > Without a scope defined, UPower assumes that the battery is provide > power to the computer it's connected to I wrote that? s/is provide/provides/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 17 Jan 2017, Benjamin Tissoires wrote: > From: Bastien Nocera <hadess@hadess.net> > > Without a scope defined, UPower assumes that the battery is provide > power to the computer it's connected to, like a laptop battery or a UPS. > > Tested-by: Peter Hutterer <peter.hutterer@who-t.net> > Signed-off-by: Bastien Nocera <hadess@hadess.net> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 4eeb550..4aaf237 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, > static enum power_supply_property hidpp_battery_props[] = { > POWER_SUPPLY_PROP_STATUS, > POWER_SUPPLY_PROP_CAPACITY, > + POWER_SUPPLY_PROP_SCOPE, Actually, what is the code baseline for this patchset please? I don't think I've ever seen hidpp_battery_props[] before. Thanks,
On Jan 20 2017 or thereabouts, Jiri Kosina wrote: > On Tue, 17 Jan 2017, Benjamin Tissoires wrote: > > > From: Bastien Nocera <hadess@hadess.net> > > > > Without a scope defined, UPower assumes that the battery is provide > > power to the computer it's connected to, like a laptop battery or a UPS. > > > > Tested-by: Peter Hutterer <peter.hutterer@who-t.net> > > Signed-off-by: Bastien Nocera <hadess@hadess.net> > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > --- > > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > > index 4eeb550..4aaf237 100644 > > --- a/drivers/hid/hid-logitech-hidpp.c > > +++ b/drivers/hid/hid-logitech-hidpp.c > > @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, > > static enum power_supply_property hidpp_battery_props[] = { > > POWER_SUPPLY_PROP_STATUS, > > POWER_SUPPLY_PROP_CAPACITY, > > + POWER_SUPPLY_PROP_SCOPE, > > Actually, what is the code baseline for this patchset please? I don't > think I've ever seen hidpp_battery_props[] before. > Sorry, I should have mentioned this was on top of your for-4.8/logitech-hidpp-battery (merged with for-next, but which was put on hold since last Summer). Cheers, Benjamin > Thanks, > > -- > Jiri Kosina > SUSE Labs > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 20 Jan 2017, Benjamin Tissoires wrote: > > > Without a scope defined, UPower assumes that the battery is provide > > > power to the computer it's connected to, like a laptop battery or a UPS. > > > > > > Tested-by: Peter Hutterer <peter.hutterer@who-t.net> > > > Signed-off-by: Bastien Nocera <hadess@hadess.net> > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > > --- > > > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > > > index 4eeb550..4aaf237 100644 > > > --- a/drivers/hid/hid-logitech-hidpp.c > > > +++ b/drivers/hid/hid-logitech-hidpp.c > > > @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, > > > static enum power_supply_property hidpp_battery_props[] = { > > > POWER_SUPPLY_PROP_STATUS, > > > POWER_SUPPLY_PROP_CAPACITY, > > > + POWER_SUPPLY_PROP_SCOPE, > > > > Actually, what is the code baseline for this patchset please? I don't > > think I've ever seen hidpp_battery_props[] before. > > > > Sorry, I should have mentioned this was on top of your > for-4.8/logitech-hidpp-battery (merged with for-next, but which was put > on hold since last Summer). Ah, so I *did* see it, but forgot :) Thanks. I'll look at the patchset in proper context now.
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 4eeb550..4aaf237 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, static enum power_supply_property hidpp_battery_props[] = { POWER_SUPPLY_PROP_STATUS, POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_SCOPE, }; static int hidpp_battery_get_property(struct power_supply *psy, @@ -777,6 +778,9 @@ static int hidpp_battery_get_property(struct power_supply *psy, case POWER_SUPPLY_PROP_CAPACITY: val->intval = hidpp->battery.level; break; + case POWER_SUPPLY_PROP_SCOPE: + val->intval = POWER_SUPPLY_SCOPE_DEVICE; + break; default: ret = -EINVAL; break;