| Message ID | 20170117225459.4438-2-afaerber@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 01/17/2017 11:54 PM, Andreas Färber wrote: > Cc: ada@kingnoval.com > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) > but this got out of order with nexbox,a95x - so inserting kingnovel between > amlogic and nexbox here. If that's what we want going forward, we should move > the old entries to make the scheme clearer. The alternative would be to > reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs > makes it difficult to categorize, we could choose gxbb as the earlier one. Andreas, Feel free to provide a fixup. Neil > > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt > index 9b2b41ab6817..fb0ee7d9a921 100644 > --- a/Documentation/devicetree/bindings/arm/amlogic.txt > +++ b/Documentation/devicetree/bindings/arm/amlogic.txt > @@ -45,5 +45,6 @@ Board compatible values: > - "amlogic,p231" (Meson gxl s905d) > - "amlogic,q200" (Meson gxm s912) > - "amlogic,q201" (Meson gxm s912) > + - "kingnovel,r-box-pro" (Meson gxm S912) > - "nexbox,a95x" (Meson gxbb or Meson gxl s905x) > - "nexbox,a1" (Meson gxm s912) >
Am 18.01.2017 um 10:35 schrieb Neil Armstrong: > On 01/17/2017 11:54 PM, Andreas Färber wrote: >> Cc: ada@kingnoval.com >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) >> but this got out of order with nexbox,a95x - so inserting kingnovel between >> amlogic and nexbox here. If that's what we want going forward, we should move >> the old entries to make the scheme clearer. The alternative would be to >> reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs >> makes it difficult to categorize, we could choose gxbb as the earlier one. > > Andreas, > > Feel free to provide a fixup. Sure, the question is which way. ;) Kevin? Carlo? Cheers, Andreas
Andreas Färber <afaerber@suse.de> writes: > Am 18.01.2017 um 10:35 schrieb Neil Armstrong: >> On 01/17/2017 11:54 PM, Andreas Färber wrote: >>> Cc: ada@kingnoval.com >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) >>> but this got out of order with nexbox,a95x - so inserting kingnovel between >>> amlogic and nexbox here. If that's what we want going forward, we should move >>> the old entries to make the scheme clearer. The alternative would be to >>> reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs >>> makes it difficult to categorize, we could choose gxbb as the earlier one. >> >> Andreas, >> >> Feel free to provide a fixup. > > Sure, the question is which way. ;) Kevin? Carlo? I don't have a strong preference, but continuing to group by SoC makes the most sense based on what we have there now. Moving nexbox,a95x up to the first one (gxbb) is fine with me. Kevin
On Tue, Jan 17, 2017 at 11:54:58PM +0100, Andreas Färber wrote: > Cc: ada@kingnoval.com > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) > but this got out of order with nexbox,a95x - so inserting kingnovel between > amlogic and nexbox here. If that's what we want going forward, we should move > the old entries to make the scheme clearer. The alternative would be to > reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs > makes it difficult to categorize, we could choose gxbb as the earlier one. > > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt index 9b2b41ab6817..fb0ee7d9a921 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.txt +++ b/Documentation/devicetree/bindings/arm/amlogic.txt @@ -45,5 +45,6 @@ Board compatible values: - "amlogic,p231" (Meson gxl s905d) - "amlogic,q200" (Meson gxm s912) - "amlogic,q201" (Meson gxm s912) + - "kingnovel,r-box-pro" (Meson gxm S912) - "nexbox,a95x" (Meson gxbb or Meson gxl s905x) - "nexbox,a1" (Meson gxm s912)
Cc: ada@kingnoval.com Signed-off-by: Andreas Färber <afaerber@suse.de> --- Originally I thought we would group by SoC (6, 8, 8b, gxbb, gxl, gmx, etc.) but this got out of order with nexbox,a95x - so inserting kingnovel between amlogic and nexbox here. If that's what we want going forward, we should move the old entries to make the scheme clearer. The alternative would be to reorder alphabetically within each SoC group, but nexbox,a95x with two SoCs makes it difficult to categorize, we could choose gxbb as the earlier one. Documentation/devicetree/bindings/arm/amlogic.txt | 1 + 1 file changed, 1 insertion(+)