btrfs-progs: lowmem-check: Fix false alert on dropped leaf
diff mbox

Message ID 20170118052107.7394-1-quwenruo@cn.fujitsu.com
State Accepted
Headers show

Commit Message

Qu Wenruo Jan. 18, 2017, 5:21 a.m. UTC
For btrfs-progs test case 021-partially-dropped-snapshot-case, if the
first leaf is already dropped, btrfs check low-memory mode will report
false alert:

checking fs roots
checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000

This is caused by we are calling check_fs_first_inode() function,
unlike the rest part of check_fs_root_v2(), it doesn't have enough check
on dropping progress, and caused the false alert.

Fix it by checking dropping progress before searching slot.

Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
 cmds-check.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

David Sterba Jan. 20, 2017, 6:21 p.m. UTC | #1
On Wed, Jan 18, 2017 at 01:21:07PM +0800, Qu Wenruo wrote:
> For btrfs-progs test case 021-partially-dropped-snapshot-case, if the
> first leaf is already dropped, btrfs check low-memory mode will report
> false alert:
> 
> checking fs roots
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
> 
> This is caused by we are calling check_fs_first_inode() function,
> unlike the rest part of check_fs_root_v2(), it doesn't have enough check
> on dropping progress, and caused the false alert.
> 
> Fix it by checking dropping progress before searching slot.
> 
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/cmds-check.c b/cmds-check.c
index 1dba2985..25247fd9 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -4939,11 +4939,18 @@  static int check_fs_first_inode(struct btrfs_root *root, unsigned int ext_ref)
 	int err = 0;
 	int ret;
 
-	btrfs_init_path(&path);
 	key.objectid = BTRFS_FIRST_FREE_OBJECTID;
 	key.type = BTRFS_INODE_ITEM_KEY;
 	key.offset = 0;
 
+	/* For root being dropped, we don't need to check first inode */
+	if (btrfs_root_refs(&root->root_item) == 0 &&
+	    btrfs_disk_key_objectid(&root->root_item.drop_progress) >=
+	    key.objectid)
+		return 0;
+
+	btrfs_init_path(&path);
+
 	ret = btrfs_search_slot(NULL, root, &key, &path, 0, 0);
 	if (ret < 0)
 		goto out;