Patchwork [1/3] drm/exynos: Remove Kconfig deps for FIMD and DECON7

login
register
mail settings
Submitter Tobias Jakobi
Date Jan. 20, 2017, 4:02 p.m.
Message ID <1484928172-16784-1-git-send-email-tjakobi@math.uni-bielefeld.de>
Download mbox | patch
Permalink /patch/9528881/
State New
Headers show

Comments

Tobias Jakobi - Jan. 20, 2017, 4:02 p.m.
While the Kconfig entries of FIMD and DECON7 both select
FB_MODE_HELPERS, the code doesn't use any of the functionality.

Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 drivers/gpu/drm/exynos/Kconfig | 2 --
 1 file changed, 2 deletions(-)
Daniel Vetter - Jan. 23, 2017, 8:36 a.m.
On Fri, Jan 20, 2017 at 05:02:50PM +0100, Tobias Jakobi wrote:
> While the Kconfig entries of FIMD and DECON7 both select
> FB_MODE_HELPERS, the code doesn't use any of the functionality.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>

Applied (just this patch) to drm-misc, since that Kconfig stuff also went
in through drm-misc. I'll leave the other 2 for exynos drivers for proper
review.

Thanks, Daniel
> ---
>  drivers/gpu/drm/exynos/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
> index d706ca4..1d18534 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -19,7 +19,6 @@ comment "CRTCs"
>  config DRM_EXYNOS_FIMD
>  	bool "FIMD"
>  	depends on !FB_S3C
> -	select FB_MODE_HELPERS
>  	select MFD_SYSCON
>  	help
>  	  Choose this option if you want to use Exynos FIMD for DRM.
> @@ -32,7 +31,6 @@ config DRM_EXYNOS5433_DECON
>  config DRM_EXYNOS7_DECON
>  	bool "DECON on Exynos7"
>  	depends on !FB_S3C
> -	select FB_MODE_HELPERS
>  	help
>  	  Choose this option if you want to use Exynos DECON for DRM.
>  
> -- 
> 2.7.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index d706ca4..1d18534 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -19,7 +19,6 @@  comment "CRTCs"
 config DRM_EXYNOS_FIMD
 	bool "FIMD"
 	depends on !FB_S3C
-	select FB_MODE_HELPERS
 	select MFD_SYSCON
 	help
 	  Choose this option if you want to use Exynos FIMD for DRM.
@@ -32,7 +31,6 @@  config DRM_EXYNOS5433_DECON
 config DRM_EXYNOS7_DECON
 	bool "DECON on Exynos7"
 	depends on !FB_S3C
-	select FB_MODE_HELPERS
 	help
 	  Choose this option if you want to use Exynos DECON for DRM.