[v2] drm/i915: reinstate call to trace_i915_vma_bind
diff mbox

Message ID 1484949083-11430-1-git-send-email-daniele.ceraolospurio@intel.com
State New
Headers show

Commit Message

Daniele Ceraolo Spurio Jan. 20, 2017, 9:51 p.m. UTC
The call went away in:

commit 3b16525cc4c1a43e9053cfdc414356eea24bdfad
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Aug 4 16:32:25 2016 +0100

    drm/i915: Split insertion/binding of an object into the VM

It is useful to have this trace as it pairs nicely with the vma_unbind
one to track vma activity.
Added inside the i915_vma_bind function (was outside before) to keep a
similar placement as trace_i915_vma_unbind.

v2: print bind_flags instead of flags (Chris)

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/i915_vma.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson Jan. 21, 2017, 11:28 a.m. UTC | #1
On Fri, Jan 20, 2017 at 01:51:23PM -0800, Daniele Ceraolo Spurio wrote:
> The call went away in:
> 
> commit 3b16525cc4c1a43e9053cfdc414356eea24bdfad
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Thu Aug 4 16:32:25 2016 +0100
> 
>     drm/i915: Split insertion/binding of an object into the VM
> 
> It is useful to have this trace as it pairs nicely with the vma_unbind
> one to track vma activity.
> Added inside the i915_vma_bind function (was outside before) to keep a
> similar placement as trace_i915_vma_unbind.
> 
> v2: print bind_flags instead of flags (Chris)
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Pushed, thanks for the patch.
-Chris

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 635f263..9d32696 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -253,6 +253,7 @@  int i915_vma_bind(struct i915_vma *vma, enum i915_cache_level cache_level,
 			return ret;
 	}
 
+	trace_i915_vma_bind(vma, bind_flags);
 	ret = vma->vm->bind_vma(vma, cache_level, bind_flags);
 	if (ret)
 		return ret;